FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: fix fixture parsing with lowered async with esbuild 0.25.3 by hi-ogawa · Pull Request #7921 · vitest-dev/vitest · GitHub

fix: fix fixture parsing with lowered async with esbuild 0.25.3 - #7921

Merged
sheremet-va merged 3 commits into
vitest-dev:mainfrom
hi-ogawa:05-02-chore_deps_update_vite
May 2, 2025
Merged

sheremet-va merged 3 commits into
vitest-dev:mainfrom
hi-ogawa:05-02-chore_deps_update_vite

Conversation

hi-ogawa commented May 2, 2025
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Esbuild 0.25.3 changed async lowering, so we need to adjust the pattern https://github.com/evanw/esbuild/releases/tag/v0.25.3. I noticed the error on Vite ecosystem ci. https://github.com/vitejs/vite-ecosystem-ci/actions/runs/14787597201/job/41518726162#step:8:1402

CI pass with latest Vite is confirmed https://github.com/vitest-dev/vitest/actions/runs/14788398666/job/41520918643?pr=7921

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify Bot commented May 2, 2025
edited
Loading

Copy link
Copy Markdown

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a912f8c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/68144593e7369d00083ca3a4
😎 Deploy Preview https://deploy-preview-7921--vitest-dev.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hi-ogawa changed the title fix: fix fixture parsing with lowered async fix: fix fixture parsing with lowered async with esbuild 0.25.3 May 2, 2025
hi-ogawa marked this pull request as ready for review May 2, 2025 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL