This addresses the slowdown reported in #549. The parser and loader accumulated their results with array_merge inside array_reduce, which made loading O(n²) in the number of entries; both now append to a local array instead. Values that are plain literals, or single or double quoted literals containing no escapes, variables or nested quotes, now skip the token state machine entirely, and a few internal call sites avoid unnecessary closure and option allocations. Loading a 2,000 line file is around 4 times faster on PHP 8.4 and 3.6 times faster on PHP 7.4, scaling is now linear, and behaviour was verified unchanged against the previous implementation across PHP 7.2 to 8.5. The one visible fix is that names consisting only of digits now keep their keys in the array returned by load and parse instead of being renumbered by array_merge, which is covered by a new test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the slowdown reported in #549. The parser and loader accumulated their results with array_merge inside array_reduce, which made loading O(n²) in the number of entries; both now append to a local array instead. Values that are plain literals, or single or double quoted literals containing no escapes, variables or nested quotes, now skip the token state machine entirely, and a few internal call sites avoid unnecessary closure and option allocations. Loading a 2,000 line file is around 4 times faster on PHP 8.4 and 3.6 times faster on PHP 7.4, scaling is now linear, and behaviour was verified unchanged against the previous implementation across PHP 7.2 to 8.5. The one visible fix is that names consisting only of digits now keep their keys in the array returned by load and parse instead of being renumbered by array_merge, which is covered by a new test.