The value parser rebuilt an immutable value object once per lexer token, copying the whole accumulated string and recomputing its length each time, which is quadratic in the length of a value composed of many small tokens, so a single call to the public parse method on an adversarial value takes seconds. This accumulates the characters and variable offsets directly and builds the value once, removing the repeated immutable value and prefix reconstruction and substantially reducing allocations and copying. Parsing a single entry whose 16MB double-quoted value contains an escaped dollar, which forces the chunked lexer path, drops from 12.4s to 75ms on PHP 8.4, and an unquoted value of 80,000 inline variable markers drops from 9.2s to 101ms, with measured scaling exponents of about 1.0 against 1.9 before; the same shapes measure linear on PHP 7.2, 7.4, 8.2 and 8.3, and output is byte-identical over a 211,158-input differential corpus. This is stacked on #603.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value parser rebuilt an immutable value object once per lexer token, copying the whole accumulated string and recomputing its length each time, which is quadratic in the length of a value composed of many small tokens, so a single call to the public parse method on an adversarial value takes seconds. This accumulates the characters and variable offsets directly and builds the value once, removing the repeated immutable value and prefix reconstruction and substantially reducing allocations and copying. Parsing a single entry whose 16MB double-quoted value contains an escaped dollar, which forces the chunked lexer path, drops from 12.4s to 75ms on PHP 8.4, and an unquoted value of 80,000 inline variable markers drops from 9.2s to 101ms, with measured scaling exponents of about 1.0 against 1.9 before; the same shapes measure linear on PHP 7.2, 7.4, 8.2 and 8.3, and output is byte-identical over a 211,158-input differential corpus. This is stacked on #603.