FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add regression tests for existing behaviour by GrahamCampbell · Pull Request #608 · vlucas/phpdotenv · GitHub

Add regression tests for existing behaviour - #608

Merged
GrahamCampbell merged 6 commits into
masterfrom
tests/coverage-hardening
Aug 24, 2026
Merged

Add regression tests for existing behaviour#608
GrahamCampbell merged 6 commits into
masterfrom
tests/coverage-hardening

Conversation

GrahamCampbell commented Aug 24, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

Several behaviours that users rely on had no pinning test, so plausible regressions passed silently: interpolation immediately after multibyte text, the anchor that keeps an escaped nested reference literal next to a bare dollar sign, indented comments, and UTF-16 and UTF-32 files carrying a byte order mark with a matching file encoding. Two test helpers also ignored their expected-name argument. The immutable load test asserted only that getenv was unchanged, which the safe factories never write anyway, so it passed vacuously; it now asserts the load return value and each environment channel. This adds targeted coverage and fixes the helpers. This is stacked on #607.

GrahamCampbell force-pushed the tests/coverage-hardening branch from 54680e7 to a21b352 Compare August 24, 2026 01:01
GrahamCampbell changed the title High-value regression tests for existing behaviour Add regression tests for existing behaviour Aug 24, 2026
GrahamCampbell force-pushed the tests/coverage-hardening branch from a21b352 to 60feb0b Compare August 24, 2026 10:45
GrahamCampbell force-pushed the tests/coverage-hardening branch from 60feb0b to 21cd0f5 Compare August 24, 2026 13:25
GrahamCampbell force-pushed the tests/coverage-hardening branch from 21cd0f5 to 0945774 Compare August 24, 2026 17:28
GrahamCampbell force-pushed the tests/coverage-hardening branch from 0945774 to 86ddd73 Compare August 24, 2026 17:43
GrahamCampbell force-pushed the tests/coverage-hardening branch from 86ddd73 to 415b11c Compare August 24, 2026 17:46
GrahamCampbell force-pushed the tests/coverage-hardening branch from 415b11c to ea4b204 Compare August 24, 2026 17:47
GrahamCampbell force-pushed the tests/coverage-hardening branch from ea4b204 to d135fe5 Compare August 24, 2026 17:49
GrahamCampbell force-pushed the tests/coverage-hardening branch from d135fe5 to c34c7b1 Compare August 24, 2026 17:56
GrahamCampbell force-pushed the tests/coverage-hardening branch from c34c7b1 to 4bf5e0d Compare August 24, 2026 17:57
Base automatically changed from fix/diagnostics to master August 24, 2026 18:03
GrahamCampbell force-pushed the tests/coverage-hardening branch from 4bf5e0d to 7da2cde Compare August 24, 2026 18:03
GrahamCampbell merged commit eec19ee into master Aug 24, 2026
44 checks passed
GrahamCampbell deleted the tests/coverage-hardening branch August 24, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL