Several behaviours that users rely on had no pinning test, so plausible regressions passed silently: interpolation immediately after multibyte text, the anchor that keeps an escaped nested reference literal next to a bare dollar sign, indented comments, and UTF-16 and UTF-32 files carrying a byte order mark with a matching file encoding. Two test helpers also ignored their expected-name argument. The immutable load test asserted only that getenv was unchanged, which the safe factories never write anyway, so it passed vacuously; it now asserts the load return value and each environment channel. This adds targeted coverage and fixes the helpers. This is stacked on #607.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several behaviours that users rely on had no pinning test, so plausible regressions passed silently: interpolation immediately after multibyte text, the anchor that keeps an escaped nested reference literal next to a bare dollar sign, indented comments, and UTF-16 and UTF-32 files carrying a byte order mark with a matching file encoding. Two test helpers also ignored their expected-name argument. The immutable load test asserted only that getenv was unchanged, which the safe factories never write anyway, so it passed vacuously; it now asserts the load return value and each environment channel. This adds targeted coverage and fixes the helpers. This is stacked on #607.