FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Resolve the strictness baseline entries at source by GrahamCampbell · Pull Request #614 · vlucas/phpdotenv · GitHub

Resolve the strictness baseline entries at source - #614

Merged
GrahamCampbell merged 1 commit into
masterfrom
types/baseline-resolution
Aug 24, 2026
Merged

Resolve the strictness baseline entries at source#614
GrahamCampbell merged 1 commit into
masterfrom
types/baseline-resolution

Conversation

GrahamCampbell commented Aug 24, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

Four of the five phpstan baseline entries point at real, if harmless, looseness in the code
rather than at annotation gaps, so this resolves them at source. The lexer now compares the
preg_match result against one explicitly, which throws in exactly the same cases as the previous
falsy check. The byte order mark comparison in Str::utf8 uses strict equality, which agrees with
the loose comparison for every value substr can produce there. The environment adapters split
their read chains so the scalar filter's guarantee is stated once as a checked narrowing instead
of an unverifiable string cast on the mapped result. The regenerated baseline shrinks to the
single remaining lexer entry, where phpstan cannot infer the type of the static pattern cache.

GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 0747e73 to 249d61b Compare August 24, 2026 13:26
GrahamCampbell force-pushed the types/baseline-resolution branch from 0e57aa7 to 4cc3c2a Compare August 24, 2026 13:27
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 249d61b to 7c4d726 Compare August 24, 2026 17:28
GrahamCampbell force-pushed the types/baseline-resolution branch from 4cc3c2a to 522b49c Compare August 24, 2026 17:28
GrahamCampbell changed the title Resolve the remaining static analysis baseline entries Resolve the strictness baseline entries at source Aug 24, 2026
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 7c4d726 to 38229c3 Compare August 24, 2026 17:43
GrahamCampbell force-pushed the types/baseline-resolution branch from 522b49c to c495f0e Compare August 24, 2026 17:43
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 38229c3 to e301a32 Compare August 24, 2026 17:46
GrahamCampbell force-pushed the types/baseline-resolution branch from c495f0e to 1f4342b Compare August 24, 2026 17:46
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from e301a32 to 9db8148 Compare August 24, 2026 17:47
GrahamCampbell force-pushed the types/baseline-resolution branch from 1f4342b to b4bd9fa Compare August 24, 2026 17:47
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 9db8148 to 3711d78 Compare August 24, 2026 17:49
GrahamCampbell force-pushed the types/baseline-resolution branch from b4bd9fa to 1f6498b Compare August 24, 2026 17:49
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 3711d78 to b70ea90 Compare August 24, 2026 17:56
GrahamCampbell force-pushed the types/baseline-resolution branch from 1f6498b to 2afb67c Compare August 24, 2026 17:56
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from b70ea90 to 860d89a Compare August 24, 2026 17:57
GrahamCampbell force-pushed the types/baseline-resolution branch from 2afb67c to c3d20b3 Compare August 24, 2026 17:57
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 860d89a to b216f12 Compare August 24, 2026 18:03
GrahamCampbell force-pushed the types/baseline-resolution branch from c3d20b3 to 24e2c50 Compare August 24, 2026 18:03
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from b216f12 to 7f6f3bd Compare August 24, 2026 18:04
GrahamCampbell force-pushed the types/baseline-resolution branch from 24e2c50 to 13590f9 Compare August 24, 2026 18:04
GrahamCampbell force-pushed the docs/behaviour-clarifications branch from 7f6f3bd to ac48f57 Compare August 24, 2026 18:04
GrahamCampbell force-pushed the types/baseline-resolution branch from 13590f9 to 3614321 Compare August 24, 2026 18:04
Base automatically changed from docs/behaviour-clarifications to master August 24, 2026 18:06
GrahamCampbell force-pushed the types/baseline-resolution branch from 3614321 to f656b3a Compare August 24, 2026 18:06
GrahamCampbell merged commit 301c079 into master Aug 24, 2026
44 checks passed
GrahamCampbell deleted the types/baseline-resolution branch August 24, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL