Four of the five phpstan baseline entries point at real, if harmless, looseness in the code
rather than at annotation gaps, so this resolves them at source. The lexer now compares the
preg_match result against one explicitly, which throws in exactly the same cases as the previous
falsy check. The byte order mark comparison in Str::utf8 uses strict equality, which agrees with
the loose comparison for every value substr can produce there. The environment adapters split
their read chains so the scalar filter's guarantee is stated once as a checked narrowing instead
of an unverifiable string cast on the mapped result. The regenerated baseline shrinks to the
single remaining lexer entry, where phpstan cannot infer the type of the static pattern cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four of the five phpstan baseline entries point at real, if harmless, looseness in the code
rather than at annotation gaps, so this resolves them at source. The lexer now compares the
preg_match result against one explicitly, which throws in exactly the same cases as the previous
falsy check. The byte order mark comparison in Str::utf8 uses strict equality, which agrees with
the loose comparison for every value substr can produce there. The environment adapters split
their read chains so the scalar filter's guarantee is stated once as a checked narrowing instead
of an unverifiable string cast on the mapped result. The regenerated baseline shrinks to the
single remaining lexer entry, where phpstan cannot infer the type of the static pattern cache.