Modify --registry-ca flag's help info - #8500
Open
YanzhaoLi wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
YanzhaoLi
requested review from
DanielXiao,
luwang-vmware,
renmaosheng and
wjun
and removed request for
renmaosheng
March 18, 2019 07:52
wjun
reviewed
Mar 19, 2019
Comment thread
cmd/vic-machine/common/registries.go
Outdated
| cli.StringSliceFlag{ | ||
| Name: "registry-ca, rc", | ||
| Usage: "Specify a list of additional certificate authority files to use to verify secure registry servers", | ||
| Usage: "Specify a list of certificate authority files to replace old ones to verify secure registry servers", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
For the first time, there is no any existing ones, so I suggest to remove "replace old ones" here.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done
Sorry, something went wrong.
Specify the replace behavior of --registry-ca flag
YanzhaoLi
force-pushed
the
topic/modify-registry-ca-help-info
branch
from
529017f to
c0ed946
Compare
March 19, 2019 10:30
wjun
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 2 approving reviews are required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify the replace behavior of --registry-ca flag
Fixes #8176