FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

starship: update to 0.51.0 by folliehiyuki · Pull Request #29705 · void-linux/void-packages · GitHub

/ void-packages Public

starship: update to 0.51.0 - #29705

Closed
folliehiyuki wants to merge 1 commit into
void-linux:masterfrom
folliehiyuki:starship-update
ConversationCommits (1)ChecksFiles changed
Closed

starship: update to 0.51.0#29705
folliehiyuki wants to merge 1 commit into
void-linux:masterfrom
folliehiyuki:starship-update

Conversation

folliehiyuki commented Mar 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

ericonr reviewed Mar 23, 2021
View reviewed changes
Comment thread srcpkgs/starship/update Outdated
Comment on lines +1 to +2
site='https://github.com/starship/starship/releases'
pattern='v\K[\d]+\.[\d]+\.[\d]+'

ericonr Mar 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you check if

Suggested change
site='https://github.com/starship/starship/releases'
pattern='v\K[\d]+\.[\d]+\.[\d]+'
site='https://github.com/starship/starship'

works?

folliehiyuki Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doesn't seem to work

Comment thread srcpkgs/starship/template
Comment on lines -7 to -8
hostmakedepends="pkg-config libgit2-devel"
makedepends="openssl-devel libgit2-devel"

ericonr Mar 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why remove libgit2 now?

ericonr Mar 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is probably not picking up because we have 1.0 (see #28456), which means it builds a statically linked libgit2. But libgit2-devel also pulls in zlib-devel, which is necessary here, otherwise it will also build a statically linked copy of zlib.

folliehiyuki Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah yes my mistake. I forgot that PR hasn't been merged

ericonr commented Apr 4, 2021

Copy link
Copy Markdown
Member

I don't think the update file is necessary anymore?

folliehiyuki commented Apr 4, 2021

Copy link
Copy Markdown
Contributor Author

Yes deleted

ericonr commented Apr 4, 2021

Copy link
Copy Markdown
Member

Maybe report

  left: `Some("\u{1b}[1;33mastronaut\u{1b}[0m in ")`,
 right: `Some("\u{1b}[1;31mastronaut\u{1b}[0m in ")`', src/modules/username.rs:156:9

their way?

ericonr closed this in c12384b Apr 4, 2021
folliehiyuki deleted the starship-update branch April 4, 2021 23:48
github-actions Bot locked as resolved and limited conversation to collaborators Jul 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

ericonr ericonr left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL