feat: add useDefineForClassFields playground fixture and pass tsconfig to Rolldown - #82
Merged
Brooooooklyn merged 3 commits intoMar 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…g to Rolldown - Add tsconfig.base.json with useDefineForClassFields: false (non-standard name to test extends chain resolution) - Add CasesComponent fixture with inject(), private fields (#view), and field cross-references - Pass tsconfig to Rolldown via resolvedConfig.build.rolldownOptions.tsconfig - Wire CasesComponent into playground routes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sorry, something went wrong.
Comment thread
napi/angular-compiler/vite-plugin/index.ts
Outdated
Move rolldownOptions.tsconfig from configResolved mutation to the config hook's return value, so Vite properly deep-merges it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Sorry, something went wrong.
Comment thread
napi/angular-compiler/vite-plugin/index.ts
Outdated
Avoid passing undefined tsconfig which could override Rolldown's auto-discovery default. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #73
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Medium Risk
Touches build tooling configuration by injecting tsconfig into Rolldown and upgrades core toolchain dependencies (Vite/Rolldown), which could subtly affect bundling behavior across environments.
Overview
Adds support in @oxc-angular/vite to forward options.tsconfig into Vite’s build.rolldownOptions.tsconfig, enabling Rolldown to resolve TypeScript settings/extends chains during builds.
Updates the playground to include a tsconfig.base.json (with useDefineForClassFields: false) and a new CasesComponent route/fixture exercising inject(), native/private class fields, and cross-field initialization order.
Bumps workspace Vite to 8.0.0-beta.16 (and related lockfile updates for rolldown/lightningcss).
Written by Cursor Bugbot for commit d87738e. This will update automatically on new commits. Configure here.