ci: default tests to latest, add pkg.pr.new dispatch input - #74
Merged
fengmk2 merged 1 commit intoMay 29, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove the `version: [latest, alpha]` matrix from every test job so push/PR/merge_group runs only exercise the latest published Vite+. Add a `workflow_dispatch` input (`pr_version`) for verifying an unreleased Vite+ build on demand. It feeds a workflow-level `VP_PR_VERSION` env var, which the install script checks before `VP_VERSION` and uses to pull the matching build from pkg.pr.new — so a single manual run verifies a candidate across the whole matrix. The value is empty on every other event, which the install script treats as unset and falls back to latest. The build job is pinned to latest (`VP_PR_VERSION: ""`) so a pre-release bundler can't shift dist/ output and fail the "dist is up to date" diff.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI to test the default latest Vite+ release on normal events while allowing manual workflow dispatches to verify an unreleased pkg.pr.new Vite+ build via VP_PR_VERSION.
Changes:
- Adds a workflow_dispatch pr_version input and workflow-level VP_PR_VERSION environment variable.
- Removes the latest/alpha version matrix from test jobs.
- Pins the build job to latest by clearing VP_PR_VERSION, and updates related sfw comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes alpha-channel testing and replaces it with on-demand pkg.pr.new verification triggered manually.
How pkg.pr.new testing works
pkg.pr.new builds install via VP_PR_VERSION (PR number / commit SHA), not the version input — the install script checks VP_PR_VERSION before VP_VERSION and uses it to pull the matching build from pkg.pr.new. The input feeds a workflow-level env var:
Since the action spreads ...process.env into the install, this flows straight through and wins even though the action sets VP_VERSION=latest. On every non-dispatch event the value is empty, which the script treats as unset → latest. So one manual dispatch verifies a candidate build across the entire matrix (install, node-version, cache, exec, sfw) with no source change to the action.
Notes
🤖 Generated with Claude Code