feat: add GitLab CI/CD integration for setup-vp by naokihaba · Pull Request #97 · voidzero-dev/setup-vp · GitHub

resolves #88

I thought it would be best to document the GitLab integration features as an RFC, so I’ve put everything together along with a diagram of the overall flow.

rfcs/assets/gitlab-runtime-flow.svg

@codex review

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 277acafbdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

GitLab CI Test Steps

Replace <test-ref> with the branch or commit SHA you want to test.

1. Basic smoke test

Verify that the setup works as expected under standard conditions.

include:
  - remote: "https://raw.githubusercontent.com/voidzero-dev/setup-vp/<test-ref>/gitlab/setup-vp.yml"
    inputs:
      setup-ref: "<test-ref>"
      node-version: "22"
      run-install: "true"

test:
  extends: .setup-vp
  image: node:22
  script:
    - vp --version
    - node --version
    - vp run test

For this test, check if the pipeline config is accepted and the setup correctly reaches the script section. You should see vp --version outputting the version correctly, confirming that vp install ran before the script executed.

2. Old Node image regression test

Ensure that the setup remains compatible even when using an older Node image.

include:
  - remote: "https://raw.githubusercontent.com/voidzero-dev/setup-vp/<test-ref>/gitlab/setup-vp.yml"
    inputs:
      setup-ref: "<test-ref>"
      node-version: "22"
      run-install: "false"

test:
  extends: .setup-vp
  image: node:18
  script:
    - node --version
    - vp --version

Confirm that the setup succeeds on the node:18 image. The runtime should switch to the requested Node version before setup-vp.mjs is executed.

3. Multi install entries

Test whether the run-install input correctly handles complex YAML objects.

include:
  - remote: "https://raw.githubusercontent.com/voidzero-dev/setup-vp/<test-ref>/gitlab/setup-vp.yml"
    inputs:
      setup-ref: "<test-ref>"
      node-version: "22"
      run-install: |
        - cwd: .
          args: ['--frozen-lockfile']

test:
  extends: .setup-vp
  image: node:22
  script:
    - vp --version

Verify that the pipeline configuration is valid and that run-install is parsed without errors. In the logs, you should see vp install --frozen-lockfile being executed.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Today I will set up a continuous verification repository on GitLab, and the results will be synchronized.

@codex review

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45e42bf985

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.

@codex review

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a05032c174

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…unction

@codex review

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: fa40c703e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.

@naokihaba I will run a round simplify before I merge.

- renovate: track SFW_VERSION in src/gitlab/install-sfw.ts so the GitLab copy is bumped alongside the GitHub Action one instead of freezing - install-sfw: drop unused isSfwSupported/sfwAssetName helpers and compute isMuslLinux() once on the unsupported-platform fallback path - run-install: extract applyEntryLine to remove three near-identical copies of the key/value + block-array handling, and correct the comment explaining why the runtime avoids zod/yaml (keep the fetched bundle tiny, not "shared chunks break relative imports") - rebuild dist bundles with vite-plus 0.2.2 to match the toolchain

Pull request overview

Copilot reviewed 20 out of 22 changed files in this pull request and generated 3 comments.

Actually, I'm a GitLab user! This will be helpful thank you.
I've also shared it with our SRE team, so if we run into any issues, I'll let you know.

naokihaba added 6 commits June 28, 2026 22:44

docs: add GitLab integration RFC

54d06b9

feat: add GitLab runtime template and bootstrap flow

024fde0

chore: include gitlab runtime tests in test config

f222ba2

docs: document GitLab integration usage and rollout details

894abf1

feat: add GitLab template bootstrap and documentation page

155cbb7

chore: remove generated GitLab runtime explanation page

277acaf

chatgpt-codex-connector Bot reviewed Jun 28, 2026

View reviewed changes

Comment thread gitlab/bootstrap.sh

Comment thread README.md Outdated

fix: align GitLab runtime bootstrap behavior

a2cc7ce

naokihaba marked this pull request as ready for review June 28, 2026 17:49

Copilot AI review requested due to automatic review settings June 28, 2026 17:49

Copilot started reviewing on behalf of naokihaba June 28, 2026 17:49 View session

Copilot AI reviewed Jun 28, 2026

fengmk2 self-assigned this Jun 29, 2026

fengmk2 reviewed Jun 29, 2026

View reviewed changes

Comment thread gitlab/setup-vp.mjs Outdated

naokihaba marked this pull request as draft June 29, 2026 01:39

naokihaba added 2 commits June 29, 2026 13:56

refactor: compile GitLab runtime from TypeScript

ea2c661

docs: document GitLab runtime architecture

45e42bf

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread src/gitlab/run-install.ts

fix: parse GitLab block YAML install args

23b4700

naokihaba marked this pull request as ready for review June 29, 2026 07:39

Copilot AI review requested due to automatic review settings June 29, 2026 07:39

Copilot started reviewing on behalf of naokihaba June 29, 2026 07:40 View session

Copilot AI reviewed Jun 29, 2026

naokihaba marked this pull request as draft June 29, 2026 09:06

Merge branch 'main' into main

1b51955

naokihaba marked this pull request as ready for review June 30, 2026 09:52

Copilot AI review requested due to automatic review settings July 4, 2026 12:13

Copilot started reviewing on behalf of naokihaba July 4, 2026 12:13 View session

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Comment thread gitlab/setup-vp.yml Outdated

feat: update setup-vp before_script to use heredoc for input variables

a05032c

naokihaba requested a review from fengmk2 July 4, 2026 14:38

chatgpt-codex-connector Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread gitlab/bootstrap.sh Outdated

Comment thread src/gitlab/install-sfw.ts

Comment thread src/gitlab/run-install.ts Outdated

naokihaba marked this pull request as draft July 4, 2026 16:03

naokihaba added 6 commits July 5, 2026 01:19

fix: handle download failure in setup_vp_install_viteplus_from function

a3251c9

feat: implement downloadFileWithShell function for curl and wget support

1e6364f

feat: add downloadFileWithShell function for curl and wget support

4af9165

fix: return 1 on download failure in setup_vp_install_viteplus_from f…

64c3b91

…unction

fix: prevent exposure of SETUP_VP_ENV_FILE to install subprocesses

79e3774

fix: remove SETUP_VP_ENV_FILE from environment in runInstall function

fa40c70

naokihaba marked this pull request as ready for review July 4, 2026 16:35

Copilot AI review requested due to automatic review settings July 4, 2026 16:35

Copilot started reviewing on behalf of naokihaba July 4, 2026 16:36 View session

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Comment thread README.md Outdated

docs: update feature descriptions for clarity in README.md

361e74b

fengmk2 approved these changes Jul 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 5, 2026 13:46

Copilot started reviewing on behalf of fengmk2 July 5, 2026 13:46 View session

fengmk2 merged commit 250f29c into voidzero-dev:main Jul 5, 2026
39 checks passed

Copilot AI reviewed Jul 5, 2026

View reviewed changes

naokihaba mentioned this pull request Jul 6, 2026

GitLab CI/CD (porting Github Action) voidzero-dev/vite-plus#1920

Closed

3 tasks

naokihaba mentioned this pull request Jul 25, 2026

Add GitLab CI/CD setup guidance voidzero-dev/vite-plus#2239

Closed

4 tasks

+              function parseScalar(value: string): string {
+                const trimmed = String(value || "").trim();
+                if (
+                  (trimmed.startsWith('"') && trimmed.endsWith('"')) ||
+                  (trimmed.startsWith("'") && trimmed.endsWith("'"))
+                ) {
+                  return trimmed.slice(1, -1);
+                }
+                return trimmed;
+              }

+                for (const char of body) {
+                  if (quote) {
+                    if (char === quote) quote = "";
+                    current += char;
+                    continue;
+                  }
+                  if (char === "'" || char === '"') {
+                    quote = char;
+                    current += char;
+                    continue;
+                  }
+                  if (char === ",") {
+                    pushCurrent();
+                    continue;
+                  }
+                  current += char;
+                }

+              export async function setupSfw(
+                runInstallEntries: RunInstallEntry[],
+                env: NodeJS.ProcessEnv = process.env,
+              ): Promise<InstallCommand> {
+                if (env.SETUP_VP_SFW !== "true") return "vp";
+                if (runInstallEntries.length === 0) {
+                  console.log(
+                    "setup-vp: sfw was requested but run-install is disabled; sfw will not be invoked.",
+                  );
+                  return "vp";
+                }
+                const existing = commandPath("sfw");
+                if (existing) {
+                  console.log(`setup-vp: using existing sfw on PATH: ${existing}`);
+                  return "sfw";
+                }

feat: add GitLab CI/CD integration for setup-vp by naokihaba · Pull Request #97 · voidzero-dev/setup-vp · GitHub

Uh oh!

feat: add GitLab CI/CD integration for setup-vp - #97

feat: add GitLab CI/CD integration for setup-vp#97fengmk2 merged 33 commits intovoidzero-dev:mainvoidzero-dev/setup-vp:mainfrom naokihaba:mainnaokihaba/setup-vp:mainCopy head branch name to clipboard

Conversation

naokihaba commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

naokihaba commented Jun 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

naokihaba commented Jun 28, 2026

GitLab CI Test Steps

1. Basic smoke test

2. Old Node image regression test

3. Multi install entries

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented Jun 29, 2026

Uh oh!

Uh oh!

naokihaba commented Jun 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

fengmk2 commented Jul 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

naokihaba commented Jul 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

fengmk2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

ubugeeei commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add GitLab CI/CD integration for setup-vp#97
fengmk2 merged 33 commits into
voidzero-dev:mainfrom
naokihaba:main

naokihaba commented Jun 28, 2026 •
edited
Loading