fix(global): preflight managed install bin conflicts by liangmiQwQ · Pull Request #1773 · voidzero-dev/vite-plus · GitHub

Close #1770

The current managed global install path uses a package-directory backup to recover from binary ownership conflicts after npm has already installed the package. According to #1770. That move-based backup logic can sometimes delete the package, like process kill or SIGINT.

This PR resolves managed bin conflicts before running npm install, then lets npm install directly into the final package prefix. It completely removes the backup logic and avoids potential problems. However, it may slightly reduce the installation speed (won't influence global update).

There is some behavior changes

If users run vp install -g pkga pkgb --force, while pkga and pkgb have the same bin name, even if --force flag, it will still report error. The original behavior (install both of them, and uninstall the earlier one) can be a little bit odd and inefficient after this change, since we can get the package's bins before any installation. I believe this helps simplify the implementation and ensures the transparency and semantics of --force.
Vite+ won't run the rest of packages' installation if there is a package not found. This is because the package's status can be known while checking bins, if we simply ignore npm view's error, network errors may cause bin overlapping issues.

🤖 Generated with Codex

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	836c47d
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a255a36eecf890008fad7fc

@codex

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb813a593b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codex

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8bf4974b91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codex

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3889d4eea8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codex review

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79eedb120c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

For now, based on Codex's review suggestions, I don't think this is and there is a completely effective and feasible solution that can ensure all packages can be runnable for reinstall due to npm limitation or system IO performance (#1770). Changes like this PR just make the problem happen in different conditions that is not much meaningful. I also made some local attempts, but I really didn't come up with any good ideas. So based on that, maybe keeping the backup logic will be better?

@fengmk2 thanks for reviewing, but considering what I laid out in #1773 (comment), this PR just moves the problem rather than solving it, I suggest closing it and keeping the current behavior.

I will be kind of busy in the next two weeks, but I am still thinking about a way which can completely resolve this problem. I believe it would be better to revisit this later rather than merge a solution that doesn't really address the root cause ❤️

@liangmiQwQ No problem, good luck on your exam! 💯

The global package reinstall flow introduced by #1698 installs into the final prefix, but it first moves the active prefix to a backup. An interruption can leave the installed package unavailable, and the approaches explored in #1770 and #1773 trade that failure mode for other windows where bins can still break. This PR adds an install ID to managed package metadata. Each install now writes directly to a sibling prefix such as `packages/<name>#<uuid>`, then activates that immutable directory by saving metadata after npm succeeds. The ID is a standard UUID v4 prefixed with `#`, which is filesystem-safe but invalid in npm package names. Binary dispatch, `vp env which`, `vpx`, and global outdated output resolve the active directory from metadata, so no installed prefix is moved. Metadata without `installId`, or with an empty value, continues to resolve `packages/<name>` for compatibility with existing installations. A successful reinstall deletes only the installation it directly replaced. Cleanup of any older interrupted-install directories through `vp upgrade` is intentionally left to a follow-up PR. 🤖 Generated with Codex --------- Signed-off-by: Liang <github@liangmi.dev> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>

fix(global): preflight managed install bin conflicts

94cd09b

liangmiQwQ added 7 commits June 6, 2026 16:14

clean up

b5b0d83

remove outdated test

53ee84f

fix(global): remove postinstall bin ownership recheck

d2ccb06

fix(global): keep failed npm install output intact

7343646

fix(global): inline preinstall conflict handling

2c88e41

fix(global): reuse known bins during update preflight

d820a4b

fix(global): return parsed bins from package spec

eb813a5

liangmiQwQ marked this pull request as ready for review June 6, 2026 09:55

chatgpt-codex-connector Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread crates/vite_global_cli/src/commands/global/install.rs Outdated

Comment thread crates/vite_global_cli/src/commands/global/install.rs Outdated

adjst

ab15d8b

liangmiQwQ marked this pull request as draft June 6, 2026 10:45

liangmiQwQ added 2 commits June 6, 2026 18:51

fix

ae892cf

adjust

8bf4974

chatgpt-codex-connector Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread crates/vite_global_cli/src/commands/global/install.rs

liangmiQwQ added 2 commits June 6, 2026 19:52

chore

ffa0c5f

finish

3889d4e

liangmiQwQ marked this pull request as ready for review June 6, 2026 12:46

chatgpt-codex-connector Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread crates/vite_global_cli/src/commands/global/mod.rs

fix global npm alias string bin conflicts

79eedb1

fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels Jun 6, 2026

chatgpt-codex-connector Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread crates/vite_global_cli/src/commands/global/install.rs

Comment thread crates/vite_global_cli/src/commands/global/install.rs

Comment thread crates/vite_global_cli/src/commands/global/install.rs

fengmk2 approved these changes Jun 7, 2026

View reviewed changes

Merge branch 'main' into codex/fix-global-install-bin-conflicts

836c47d

liangmiQwQ marked this pull request as draft June 7, 2026 12:06

liangmiQwQ closed this Jun 7, 2026

liangmiQwQ deleted the codex/fix-global-install-bin-conflicts branch June 7, 2026 12:29

liangmiQwQ mentioned this pull request Jun 21, 2026

fix(global): introduce install id for global installation #1906

Merged

fix(global): preflight managed install bin conflicts by liangmiQwQ · Pull Request #1773 · voidzero-dev/vite-plus · GitHub

Uh oh!

fix(global): preflight managed install bin conflicts - #1773

fix(global): preflight managed install bin conflicts#1773liangmiQwQ wants to merge 15 commits intovoidzero-dev:mainvoidzero-dev/vite-plus:mainfrom liangmiQwQ:codex/fix-global-install-bin-conflictsliangmiQwQ/vite-plus:codex/fix-global-install-bin-conflictsCopy head branch name to clipboard

Conversation

liangmiQwQ commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

liangmiQwQ commented Jun 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented Jun 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liangmiQwQ commented Jun 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fengmk2 commented Jun 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liangmiQwQ commented Jun 7, 2026

Uh oh!

fengmk2 commented Jun 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(global): preflight managed install bin conflicts#1773
liangmiQwQ wants to merge 15 commits into
voidzero-dev:mainfrom
liangmiQwQ:codex/fix-global-install-bin-conflicts

liangmiQwQ commented Jun 6, 2026 •
edited
Loading

netlify Bot commented Jun 6, 2026 •
edited
Loading

liangmiQwQ commented Jun 6, 2026 •
edited
Loading