feat(cli): use version range instead of latest for vite-plus dependencies - #1818
Closed
fengmk2 wants to merge 2 commits into
Closed
feat(cli): use version range instead of latest for vite-plus dependencies#1818fengmk2 wants to merge 2 commits into
fengmk2 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Disable git commit signing in snap fixture commits so a contributor's global commit.gpgsign config cannot break non-interactive runs, and mock getNpmRegistry in package.spec.ts so URL assertions do not depend on the developer's configured npm registry mirror.
…cies vp create and vp migrate wrote the latest dist-tag for vite-plus and the vite/vitest aliases, which made vp update vite-plus unreliable because dist-tag specs are not re-resolved consistently by package managers. Derive a caret range from the CLI's own version (cli/core/test are published in lockstep) for the vite-plus, vite-plus-core, and vite-plus-test specs. vp migrate also normalizes a legacy "vite-plus": "latest" devDependency to the range while leaving deliberate user pins untouched. The snap runner normalizes the new specs to ^<semver> so snapshots stay stable across releases. With real ranges npm also records the vite/vitest alias overrides in the lockfile; the previously failing verification step in the migration-standalone-npm snap test now passes.
Copy link
Copy Markdown
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vp create and vp migrate wrote the latest dist-tag for vite-plus and the vite/vitest aliases. Dist-tag specs are not re-resolved consistently by package managers, so vp update vite-plus was often a no-op, and npm did not record the alias overrides in the lockfile.
Changes
With real ranges npm now records the vite/vitest alias overrides in the lockfile: the previously failing verification step in the migration-standalone-npm snap test now passes.