FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for el10 by qha · Pull Request #747 · voxpupuli/puppet-python · GitHub

Add support for el10 - #747

Open
qha wants to merge 1 commit into
voxpupuli:masterfrom
qha:add-support-for-el10
Open

Add support for el10#747
qha wants to merge 1 commit into
voxpupuli:masterfrom
qha:add-support-for-el10

Conversation

qha commented Mar 27, 2026

Copy link
Copy Markdown

Pull Request (PR) description

Add support for el10.

This Pull Request (PR) fixes the following issues

qha marked this pull request as draft March 27, 2026 12:18
qha force-pushed the add-support-for-el10 branch from e7db95b to 676aefd Compare March 27, 2026 12:26

qha commented Mar 27, 2026
edited
Loading

Copy link
Copy Markdown
Author

The ci problems look very relevant but i'm not sure what to do about them.

I suspect we need a change to spec_helper_acceptance.rb similar to what the el10 support pr for epel added (installing gnupg2) but limited to osfamily Redhat too but spec_helper_acceptance.rb looks a bit different here and most of all warns it's managed by modulesync.

I would appreciate any hints or tips!

qha force-pushed the add-support-for-el10 branch from 676aefd to 679981b Compare March 27, 2026 14:46
Includes version bump of puppet/epel requirement as their support of
el10 landed in 6.0.0.

Stops syncing spec_helper_acceptance.rb to permit installing gnupg2
before testing on el10.
qha force-pushed the add-support-for-el10 branch from 679981b to a089cab Compare March 27, 2026 14:47

qha commented Mar 27, 2026

Copy link
Copy Markdown
Author

I got some advice from a colleague so i've pushed a new variant that passes ci. If unmanaging spec_helper_acceptance.rb is not acceptable then i'll need a good deal of hints to "find another way".

qha marked this pull request as ready for review March 27, 2026 14:58

configure_beaker(modules: :metadata)
configure_beaker(modules: :metadata) do |host|
host.install_package('gnupg2') if fact('os.family') == 'RedHat' && fact('os.release.major').to_i >= 10

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I really wish we didn't have to do this here.

@bastelfreak didn't we want to fix that in hostgenerator?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The reality is, this line in puppet-epel should not use gpg on el10

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't know how to properly fix the epel module (or why it even exists instead of installing the epel-release package), but we could fix this in beaker-hostgenerator if we want:

kenyon added the enhancement New feature or request label Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL