FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vsgcameras demo of viewport partially off screen by theodoregoetz · Pull Request #345 · vsg-dev/vsgExamples · GitHub

vsgcameras demo of viewport partially off screen - #345

Closed
theodoregoetz wants to merge 1 commit into
vsg-dev:masterfrom
theodoregoetz:vewport-partially-offscreen
Closed

vsgcameras demo of viewport partially off screen#345
theodoregoetz wants to merge 1 commit into
vsg-dev:masterfrom
theodoregoetz:vewport-partially-offscreen

Conversation

theodoregoetz commented Feb 11, 2025
edited
Loading

Copy link
Copy Markdown

Demonstration only!!! Do not merge to master.

This was tested against the dynamic-viewports3 branch in VulkanSceneGraph, commit: 1fac1761

The overlay views are partially off the screen. The initial rendering is good, but the model snaps to the scissors of the overlays when the window is resized. This is because the viewport gets set to the scissor in the viewportstate. It was expected that the viewport and the scissor remain independent and should be resized individually.

initial view (expected):

view after a window resize (the models should not be snapped to the scissors of the overlay views):

The overlay views are partially off the screen. The initial rendering is good, but the model snaps to the scissors of the overlays when the window is resized. This is because the viewport gets set to the scissor in the viewportstate. It was expected that the viewport and the scissor remain independent and should be resized individually.

Copy link
Copy Markdown
Collaborator

For testing purpose I have merged this PR as a branch:

https://github.com/vsg-dev/vsgExamples/tree/theodoregoetz-vewport-partially-offscreen

On resize 'vsgcameras models/teapot.vsgt' resets the viewports to the extents of the window, which from the description of the issue is the problem that needs resolving.

There is also a bug in the management of the aspect ratio of the secondary views, this is a separate issue which occurs with vsgExamples master. I will be looking at both issues.

Copy link
Copy Markdown
Collaborator

I have merged a refactor of WindowResizeHandler into VSG master that handles this usage case so that the modified vsgcameras example now works sensible:

vsg-dev/VulkanSceneGraph#1399

I'm going to close this PR as I believe it's no longer required.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL