FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix on_close propogation + bump websocket-client by wwwehr · Pull Request #817 · watson-developer-cloud/python-sdk · GitHub

/ python-sdk Public

Fix on_close propogation + bump websocket-client - #817

Open
wwwehr wants to merge 3 commits into
watson-developer-cloud:masterfrom
wehr-enterprises:master
ConversationCommits (3)ChecksFiles changed
Open

Fix on_close propogation + bump websocket-client#817
wwwehr wants to merge 3 commits into
watson-developer-cloud:masterfrom
wehr-enterprises:master

Conversation

wwwehr commented Apr 17, 2022

Copy link
Copy Markdown

Satisfies #810

Also, the websocket client class sends messages to the on_close handler that do not match the signature that result in an error:

from callback <bound method SynthesizeListener.on_close of
 <ibm_watson.websocket.synthesize_listener.SynthesizeListener object at
 0x123456789>>: on_close() takes 2 positional arguments but 4 were given

This PR fixes this issue.

CLAassistant commented Apr 17, 2022 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

wwwehr commented Jun 24, 2022

Copy link
Copy Markdown
Author

@jeff-arn @kevinkowa @Hsaylor

Hoping to get this reviewed and merged. I thought I followed the contributors notes - please advise if I need to do anything else!

apaparazzi0329 force-pushed the master branch 3 times, most recently from 0e535bc to fb4c580 Compare January 26, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL