Update HttpEce to use BC provider when calling KeyAgreement - #205
Open
frmans wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Since there already is a dependency to BouncyCastle in Utils.java it doesn't add any more restrictions doing this, also this solves the following issue web-push-libs#5
Copy link
Copy Markdown
|
This is useful patch. It helped me to reveal the problem under wildfly: https://issues.redhat.com/browse/WFLY-4576 java.security.NoSuchProviderException: JCE cannot authenticate the provider BC at javax.crypto.JceSecurity.getInstance(JceSecurity.java:105) at javax.crypto.KeyAgreement.getInstance(KeyAgreement.java:230) at nl.martijndwars.webpush.HttpEce.extractDH(HttpEce.java:360) ... Caused by: java.lang.SecurityException: Cannot verify jar:vfs:/content/runawfe.ear/lib/bcprov-debug-jdk18on-1.73.jar!/ at javax.crypto.JarVerifier.verifySingleJar(JarVerifier.java:448) ... Caused by: java.security.PrivilegedActionException: java.util.zip.ZipException: zip file is empty at java.security.AccessController.doPrivileged(Native Method) at javax.crypto.JarVerifier.verifySingleJar(JarVerifier.java:426) ... 75 more Caused by: java.util.zip.ZipException: zip file is empty at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.<init>(ZipFile.java:225) ... 77 more Suppressed: java.nio.file.NoSuchFileException: /tmp/jar_cache2337284540188290599.tmp at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86) ... 86 more |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there already is a dependency to BouncyCastle in Utils.java it doesn't add any more restrictions doing this, also this solves the following issue #5