Rename Feature/Limit to DeviceFeature/DeviceLimit - #539
Open
kainino0x wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
kainino0x
force-pushed
the
feature-limit-rename
branch
from
2d2b7b4 to
2c02f97
Compare
May 1, 2025 22:27
kainino0x
commented
May 1, 2025
Comment thread
webgpu.yml
Outdated
kainino0x
force-pushed
the
feature-limit-rename
branch
2 times, most recently
from
f8df990 to
523e0a5
Compare
May 6, 2025 00:58
With aliases for the old names.
kainino0x
force-pushed
the
feature-limit-rename
branch
from
44a953a to
d3645c9
Compare
May 6, 2025 01:07
kainino0x
marked this pull request as ready for review
May 6, 2025 01:12
Copy link
Copy Markdown
Collaborator
|
Tbh, I'm not convinced it's worth it to rename these either... Unless we feel strongly about it, I'm heavily leaning towards just leaving it as is. I think that given the InstanceFeatures have the explicit name in them it should be clear enough. |
Sorry, something went wrong.
1 task
This comment was marked as spam.
lokokung
approved these changes
Jan 20, 2026
J2085isa
approved these changes
Jan 21, 2026
cwfitzgerald
removed their request for review
August 14, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was proposed in the meeting. I'm still not really convinced this is worthwhile, but it is a little clearer (especially in C where you don't get much type safety - you can freely assign a WGPUFeatureName value to a WGPUInstanceFeatureName variable).
We could also consider just removing the old names. The migration is probably not so hard that this is necessarily worth keeping around. I did add a macro to disable the aliases though.
Also removes WGPU_TRUE/WGPU_FALSE from extension headers. Accidentally added those, they aren't needed since extensions include webgpu.h.
Fixes #522