FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle periods in directory names when interpolating paths by pugnascotia · Pull Request #71 · webpack/loader-utils · GitHub

This repository was archived by the owner on Dec 17, 2025. It is now read-only.
/ loader-utils Public archive

Handle periods in directory names when interpolating paths - #71

Merged
jhnns merged 1 commit into
webpack:masterfrom
pugnascotia:master
Mar 6, 2017
Merged

Handle periods in directory names when interpolating paths#71
jhnns merged 1 commit into
webpack:masterfrom
pugnascotia:master

Conversation

Copy link
Copy Markdown
Contributor

Given:

  • A filename without an extension, and
  • A directory path containing a period

...the result from interpolateName is wrong. I've reworked the code and added some tests to cover this.

jsf-clabot commented Feb 24, 2017
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

Copy link
Copy Markdown
Contributor Author

Aw, no fair on the decreased coverage - it's because there's fewer lines of code :-(

Copy link
Copy Markdown
Contributor Author

Maintainers - I can add tests to increase the coverage score, but that will increase the scope of these changes. What would you like me to do?

Timer commented Mar 1, 2017

Copy link
Copy Markdown

Hi!

We would love to see some feedback given on this issue so that it may be merged and released.
We're depending on it as part of our CRA react-scripts@0.10.0 release, which switches to webpack@2!
@pugnascotia has been working hard to give us a whitelisted url-loader and our comprehensive e2e uncovered this bug. 🔥

Let me know if there's anything I can do to help facilitate this process, and thanks to all parties!

/cc @jhnns

jhnns merged commit aaff808 into webpack:master Mar 6, 2017

jhnns commented Mar 6, 2017

Copy link
Copy Markdown
Contributor

Thanks! That looks good. It makes sense to use path.parse() here since loaderContext.resourcePath is a native, absolute path, so node's parsing algorithm should work as expected. I don't know why @sokra preferred to parse it manually here 😬

Published as 1.0.3

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL