require a newer version of uglify that fixes a bug with regexp - #4902
Conversation
Sorry, something went wrong.
|
trying to get the tests passing. i can't even run the master tests locally though. i get an Error: Cannot find module 'webpack/lib/removeAndDo' |
Sorry, something went wrong.
|
see CONTRIBUTING.md. yarn link yarn link webpack To update the test snapshots: mocha -g "Stats" node test/statsCases/accept-stats.js |
Sorry, something went wrong.
sokra
left a comment
There was a problem hiding this comment.
Update test snapshots
Sorry, something went wrong.
|
it's passing in travis but i still get an error locally.
|
Sorry, something went wrong.
| path = require("path"); | ||
| var source = fs.readFileSync(path.join(__dirname, "ie8.js"), "utf-8"); | ||
| source.should.containEql("function r(n){return function(n){try{t()}catch(t){n(t)}}}"); | ||
| source.should.containEql("function r(n){return function(t){try{n()}catch(n){t(n)}}}"); |
There was a problem hiding this comment.
on second thought not sure i should have switched n and t. it looks like it might change the behavior of the resulting code. but i'm not sure why the output switched either.
Sorry, something went wrong.
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Sorry, something went wrong.
|
Thanks |
Sorry, something went wrong.
What kind of change does this PR introduce?
Just requiring a newer version of uglify js that includes a bugfix mishoo/UglifyJS#1964
Did you add tests for your changes?
No code changes were made.
Summary
There was a bug in earlier versions of uglify where the reduce_vars option (which is on by default) was causing some changes to the global RegExp prototype in certain scenarios (such as if babel-polyfill is included). This could break methods like string.split when using node 6 or chrome 51.
Does this PR introduce a breaking change?
No