fix: fix webpack hanging under certain circumstance - #1078
Merged
evenstensberg merged 1 commit intoSep 17, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Sorry, something went wrong.
ematipico
approved these changes
Sep 14, 2019
rishabh3112
approved these changes
Sep 14, 2019
jamesgeorge007
approved these changes
Sep 14, 2019
evenstensberg
approved these changes
Sep 17, 2019
evenstensberg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Not required
Summary
This pull request is similar to this one: webpack/webpack#6193 merged two years ago, but in Webpack main repository.
It fixes this issue: webpack/sass-loader#759
See the previous pull request for more details.
Related issues:
nodejs/node#17872
webpack/sass-loader#523
Does this PR introduce a breaking change?
No