FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add new no-cache flag and patch sec dep by evenstensberg · Pull Request #1102 · webpack/webpack-cli · GitHub

/ webpack-cli Public

feat: add new no-cache flag and patch sec dep - #1102

Merged
evenstensberg merged 1 commit into
masterfrom
feat/no-cache-flag
Oct 31, 2019
ConversationCommits (1)ChecksFiles changed
Merged

feat: add new no-cache flag and patch sec dep#1102
evenstensberg merged 1 commit into
masterfrom
feat/no-cache-flag

Conversation

evenstensberg commented Oct 27, 2019

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?
Fixes #1095

Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
No, this needs to be done
Summary
Adds no-cache flag, (we do not check version here for setting the property)

Does this PR introduce a breaking change?
No
Other information

  • Might need to add validation against webpack version?
  • Monorepo test are failing, might worth removing the entire mono repo at master branch? (Is that good for versioning against next? I think it's bad)

evenstensberg changed the title feat: add new flag and patch sec dep feat: add new no-cache flag and patch sec dep Oct 27, 2019

webpack-bot commented Oct 27, 2019

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

ematipico approved these changes Oct 27, 2019
View reviewed changes

ematipico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

At this point why don't take the leap and release the v4 and dropping support for webpack v4?

Cli v4 will support only webpack v5

evenstensberg commented Oct 27, 2019

Copy link
Copy Markdown
Member Author

That would be great, but we need to write docs, migration guide and make sure it is stable

evenstensberg merged commit 1208aa6 into master Oct 31, 2019
evenstensberg deleted the feat/no-cache-flag branch October 31, 2019 04:39

anikethsaha commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

Cli v4 will support only webpack v5

webpack v5 is in beta, isn't it ?
Why removing support for v4? I guess many projects will still be using webpack.v4 for quite a few time in the future. cause I still see projects using v2.
Will it be like webpack-cli v3 will be for webpack v4 and less ?

snyk-bot mentioned this pull request Nov 25, 2019
Open
snyk-bot mentioned this pull request Feb 4, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
ematipico ematipico approved these changes
rishabh3112 rishabh3112 approved these changes
jamesgeorge007 jamesgeorge007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: CI-ok PR: reviewed-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL