FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: overlay displays unhandled promise rejection by malcolm-kee · Pull Request #4849 · webpack/webpack-dev-server · GitHub

/ webpack-dev-server Public

feat: overlay displays unhandled promise rejection - #4849

Merged
alexander-akait merged 1 commit into
webpack:masterfrom
malcolm-kee:feat/overlay-display-unhandled-promise-rejection
May 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

feat: overlay displays unhandled promise rejection#4849
alexander-akait merged 1 commit into
webpack:masterfrom
malcolm-kee:feat/overlay-display-unhandled-promise-rejection

Conversation

malcolm-kee commented May 7, 2023

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

overlay.runtimeErrors should capture unhandled Promise rejection, as it's still runtime error, just async in nature.

Breaking Changes

Not breaking change.

Additional Info

Part of #3689

codecov Bot commented May 7, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (51f8a1b) 91.96% compared to head (f9fe3d2) 91.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4849      +/-   ##
==========================================
- Coverage   91.96%   91.84%   -0.12%     
==========================================
  Files          16       16              
  Lines        1704     1704              
  Branches      647      647              
==========================================
- Hits         1567     1565       -2     
- Misses        126      128       +2     
  Partials       11       11

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

malcolm-kee marked this pull request as ready for review May 7, 2023 09:05
alexander-akait merged commit d1dd430 into webpack:master May 7, 2023
malcolm-kee deleted the feat/overlay-display-unhandled-promise-rejection branch May 7, 2023 13:29

yoyo837 commented May 9, 2023

Copy link
Copy Markdown
Contributor

How do I make unhandled promise rejection not overlay displays, so that it behaves the same as before.

yoyo837 commented May 9, 2023

Copy link
Copy Markdown
Contributor

How do I make unhandled promise rejection not overlay displays, so that it behaves the same as before.

overlay: {
++runtimeErrors: false,
  errors: true,
  warnings: false,
},

This is the same behavior as before.

jtoar mentioned this pull request May 11, 2023
Merged

keremcanb commented May 31, 2023

Copy link
Copy Markdown

This feature gave us so much headache that we had to downgrade to the previous version.

alexander-akait commented May 31, 2023

Copy link
Copy Markdown
Member

@keremcanb just disable it using options

keremcanb commented May 31, 2023 via email

Copy link
Copy Markdown

alexander-akait commented May 31, 2023

Copy link
Copy Markdown
Member

You can filter them, sorry we will not remove this feature

tplevko mentioned this pull request Jun 29, 2023
Open

tomasztomys commented Jun 29, 2023

Copy link
Copy Markdown

It should be break change!

Sentini14 mentioned this pull request Aug 13, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alexander-akait alexander-akait approved these changes
hiroppy Awaiting requested review from hiroppy
snitin315 Awaiting requested review from snitin315
anshumanv Awaiting requested review from anshumanv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL