FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle external upgrade for all websocket proxies by jamesblight · Pull Request #843 · webpack/webpack-dev-server · GitHub

/ webpack-dev-server Public

Handle external upgrade for all websocket proxies - #843

Merged
SpaceK33z merged 2 commits into
webpack:masterfrom
jamesblight:external-websocket-upgrade
Mar 14, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Handle external upgrade for all websocket proxies#843
SpaceK33z merged 2 commits into
webpack:masterfrom
jamesblight:external-websocket-upgrade

Conversation

jamesblight commented Mar 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change upgrades websocket proxies so that an inital http request doesn't have to be made.
https://github.com/chimurai/http-proxy-middleware#external-websocket-upgrade

It supports a proposed change in Create React App by handling the upgrade of any websocket proxy passed in. react/create-react-app#1790

I added a test to confirm the upgrade

jsf-clabot commented Mar 14, 2017 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

codecov Bot commented Mar 14, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #843 into master will increase coverage by 0.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   72.72%   73.05%   +0.33%     
==========================================
  Files           4        4              
  Lines         407      412       +5     
  Branches      119      120       +1     
==========================================
+ Hits          296      301       +5     
  Misses        111      111
Impacted Files Coverage Δ
lib/Server.js 82.97% <100%> (+0.31%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a44d1...d24fec3. Read the comment docs.

SpaceK33z merged commit d69559a into webpack:master Mar 14, 2017

SpaceK33z commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

Awesome!! Thanks, I'll release a new version today.

SpaceK33z commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

This is published in version 2.4.2.

jamesblight mentioned this pull request Mar 24, 2017
Merged

shellscape commented Oct 18, 2017

Copy link
Copy Markdown
Contributor

@jamesblight in working on version 3, we've removed SockJS for sockets across the board, instead replacing it with ws for a WebSocket Server, and native WebSocket on the client. Unfortunately, that move has "broken" tests for proxying WebSockets. The test has been moved here, on the refactor-lib branch https://github.com/webpack/webpack-dev-server/blob/refactor-lib/test/tests/proxy.js#L199. Any chance you would be willing to take a look a this setup? I've been so far unsuccessful in getting it to work.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL