Added cli option --disable-host-check - #980
Merged
shellscape merged 2 commits intoJul 10, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Will set `options.disableHostCheck` to true if enabled.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #980 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 4 4
Lines 463 463
Branches 139 139
=======================================
Hits 334 334
Misses 129 129Continue to review full report at Codecov.
|
Sorry, something went wrong.
shellscape
suggested changes
Jul 10, 2017
shellscape
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@Telokis the PR template is not optional. Please review https://github.com/webpack/webpack-dev-server/blob/master/.github/PULL_REQUEST_TEMPLATE.md, copy the template, and edit your PR with the template.
Sorry, something went wrong.
shellscape
approved these changes
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will set options.disableHostCheck to true if enabled.
This a very minor feature made to fix #882
What kind of change does this PR introduce?
A minor feature
Did you add or update the examples/?
No need to, I think.
Summary
Added cli option --disable-host-check to disable host check
Does this PR introduce a breaking change?
No
Other information
No