FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix #9 by using LF line-endings by ensconced · Pull Request #10 · whyboris/TypeScript-Call-Graph · GitHub

/ TypeScript-Call-Graph Public

fix #9 by using LF line-endings - #10

Open
ensconced wants to merge 2 commits into
whyboris:mainfrom
ensconced:fix/9-yarn-line-endings
ConversationCommits (2)ChecksFiles changed
Open

fix #9 by using LF line-endings#10
ensconced wants to merge 2 commits into
whyboris:mainfrom
ensconced:fix/9-yarn-line-endings

Conversation

ensconced commented Apr 10, 2021 •
edited
Loading

Copy link
Copy Markdown

fixes #9

After merging this in, to actually see the fixed line-endings in your working tree, you'll need to clear out your working directory, and then restore everything again by doing this:

(N.B. this will clear out any uncommitted changes you have on your branch).

git rm -r ./* && git reset --hard

Then if you open bin/index.js you should see that the line-endings are just LF rather than CR+LF. I tested this in Notepad++ (View > Show Symbol > Show End of Line).

ensconced and others added 2 commits April 10, 2021 08:24
fix whyboris#9 by using LF line-endings in working directory
85b6953 
this ensures that the bin scripts in the published package are unix-compatible
explain line-ending setting
949daf1
ensconced mentioned this pull request Apr 10, 2021
Open

whyboris commented Oct 8, 2021

Copy link
Copy Markdown
Owner

Thank you for this contribution 🙇
Sorry it's taking a while for me to get to it 😓 I've been busy with life stuff (not bad, just time-consuming).
I intend to get this merged in before the end of the year 🤞

whyboris commented Jan 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

Thank you again for this -- I'll test it on Windows once and merge 🤝

This was a great article about the topic:
https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/

I might try the command from the article git add --renormalize . 🤝

whyboris commented Jul 25, 2022

Copy link
Copy Markdown
Owner

Intending to merge/fix this problem in the coming month 🤞

whyboris commented Oct 20, 2022

Copy link
Copy Markdown
Owner

I'm hoping to catch up on updating all my repositories this winter 😅

whyboris commented Nov 2, 2024

Copy link
Copy Markdown
Owner

😓 oh it's been busy years for me ... hoping to get back to cleaning my less-frequently-used-by-me repositories in 2025 🤞

Thank you again for the PR - it's not forgotten 🙇‍♂️ ♥

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doesn't work with yarn due to CRLF line-ending

2 participants

Back | FazBrowse Home | New Git URL