Added support for class methods & constructors, closes #21 - #28
Open
almost-jay wants to merge 1 commit into
Open
Added support for class methods & constructors, closes #21#28almost-jay wants to merge 1 commit into
almost-jay wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Thank you @almost-jay for the contribution! 🙇♂️ I'm hoping to get back to coding & merging PRs in spring of 2026 🤞 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added support for class methods, including constructors, by adding a new branch to extract.ts which handles .isConstructorDeclaration(), .isCallExpression(), etc. Also changed node.getChildAt(0, sourceFile) to use node.expression, because it seemed cleaner and was necessary to parse classes properly
Have only tested this on three projects so it might have bugs I haven't noticed...