Fix option list filtering with autoload and transients - #620
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR fixes SQL WHERE clause operator-precedence issues in wp option list so that --autoload=on|off filtering does not inadvertently override transient inclusion/exclusion logic. It aligns the actual results with the command’s documented behavior: transients are excluded by default unless --transients is provided.
Changes:
- Grouped autoload conditions into a single parenthesized AND ( ... OR ... ) clause to avoid AND/OR precedence bugs.
- Grouped transient include/exclude conditions into a single parenthesized clause for consistent interaction with other filters.
- Added a Behat scenario covering --autoload=on behavior with transients (default exclusion vs --transients inclusion).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Option_Command.php | Fixes SQL condition grouping so --autoload and transient filters combine correctly. |
| features/option-list.feature | Adds/updates Behat coverage for transient exclusion by default when using --autoload=on. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Fixes an issue where wp option list --autoload=on could still include transient rows.
The command already excludes transients by default unless --transients is used. This updates the SQL condition grouping so the autoload and transient filters are applied together correctly.
Tests: