FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add build step for `wp-cli/wp-cli-shim` by swissspidy · Pull Request #592 · wp-cli/wp-cli-bundle · GitHub

/ wp-cli-bundle Public

Add build step for wp-cli/wp-cli-shim - #592

Draft
swissspidy wants to merge 15 commits into
mainfrom
try/composer-phar
ConversationCommits (15)ChecksFiles changed
Draft

Add build step for wp-cli/wp-cli-shim#592
swissspidy wants to merge 15 commits into
mainfrom
try/composer-phar

Conversation

swissspidy commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Assumes the existence of a new wp-cli/phar repository with a composer.json such as this one:

{
	"name": "wp-cli/wp-cli-shim",
	"description": "Composer-based WP-CLI Phar",
	"license": ["MIT"],
	"require": {
		"php": ">=5.6"
	},
	"conflict": {
		"wp-cli/wp-cli" : "*"
	},
	"bin": ["wp-cli.phar"]
}

And I think that's all that's needed.

To-do:

  • Add hashes and/or signature for verification
  • Maybe rename to wp-cli/wp-cli-shim or something

Fixes #134
Fixes wp-cli/ideas#145

swissspidy added the scope:distribution Related to distribution label Oct 27, 2023
swissspidy requested a review from a team as a code owner October 27, 2023 11:59

danielbachhuber commented Nov 4, 2023

Copy link
Copy Markdown
Member

@szepeviktor What do you think of this? Does it solve your needs?

szepeviktor commented Nov 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Everything from Pascal gets the Seal of Approval from me.

szepeviktor reviewed Nov 4, 2023
View reviewed changes
Comment thread .github/workflows/deployment.yml Outdated
szepeviktor reviewed Nov 4, 2023
View reviewed changes
Comment thread .github/workflows/deployment.yml Outdated
szepeviktor reviewed Nov 4, 2023
View reviewed changes
Comment thread .github/workflows/deployment.yml
schlessera requested changes Nov 10, 2023
View reviewed changes
Comment thread .github/workflows/deployment.yml Outdated
Comment thread .github/workflows/deployment.yml Outdated

schlessera commented Nov 10, 2023

Copy link
Copy Markdown
Member

@swissspidy The repository was created: https://github.com/wp-cli/wp-cli-shim

swissspidy commented Nov 10, 2023

Copy link
Copy Markdown
Member Author

@schlessera Thanks! Can you add me to the repo so I can add an initial composer.json file?

swissspidy changed the title Add build step for wp-cli/phar Add build step for wp-cli/wp-cli-shim Nov 10, 2023

schlessera commented Nov 10, 2023

Copy link
Copy Markdown
Member

@swissspidy Done.

swissspidy commented Nov 10, 2023

Copy link
Copy Markdown
Member Author

@schlessera OK so I pushed a branch intending to create a PR but because it was the first branch that became the default 🤦

https://github.com/wp-cli/wp-cli-shim

Can you make main the default, remove add-v0 and make any other changes as you see fit?

swissspidy commented Nov 10, 2023

Copy link
Copy Markdown
Member Author

@schlessera OK, so now I suppose what's left is making sure that the ACTIONS_BOT token has access to the new repo, then it should just work.

Once it does, we can tag what's currently in the repo with v2.9.0, afterwards there will be nightly updates people can use with dev-main.

Not sure if we need branch-alias there as well, that would probably complicate things.

swissspidy mentioned this pull request Dec 6, 2023
Closed
29 tasks

swissspidy commented Dec 19, 2023

Copy link
Copy Markdown
Member Author

@schlessera wanna give this a try for next release?

swissspidy mentioned this pull request Jan 29, 2024
Closed
36 tasks
swissspidy commented Feb 7, 2024
View reviewed changes
Comment thread .github/workflows/deployment.yml Outdated
swissspidy marked this pull request as draft July 1, 2025 11:38

This comment was marked as resolved.

Sign in to view
swissspidy commented Jan 12, 2026
View reviewed changes
Comment thread .github/workflows/deployment.yml Outdated
swissspidy commented Jan 12, 2026
View reviewed changes
Comment thread .github/workflows/deployment.yml Outdated

tyrann0us commented Jul 27, 2026

Copy link
Copy Markdown

Hi @swissspidy, I came here from #134. I'm aware of @johnpbloch's great https://github.com/johnpbloch/wp-cli-phar package, and we use it in our organization, but having a first-party repository would be even better (especially in times of supply chain attacks becoming worryingly regular). Therefore, please allow me to ask if there are any plans to move this PR forward.
Thanks! 🙏🏽

swissspidy commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Thanks for the ping!

Work on this kinda stalled in favor of wp-cli/wp-cli#5920, where we wanted to take a step back and identify the actual problem we're trying to solve. If you'd like to leave a comment expressing your interest & what you would like to see solved, that would be very helpful.

coderabbitai Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 30086f0e-935f-4d0e-9797-1a0e8b674bf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Fix artifact handling in shim deployment job
a2dcb34 
The `deploy-shim` job downloaded an artifact named `wp`, but the build
job uploads it as `wp-cli-phar` containing `wp-cli.phar`, so the download
failed and the subsequent `chmod`/`git add` had no file to operate on.

Download the correct artifact and rename the Phar to `wp`, which is what
`wp-cli/wp-cli-shim` declares as its `bin`.

Also align the job with the existing `deploy` job:

* Give it a distinct display name, as both were labelled "Deployment".
* Pin `actions/checkout`, `actions/download-artifact` and
  `ad-m/github-push-action` to the same SHAs used elsewhere in this
  workflow, instead of floating tags and `@master`.
* Push to `main` explicitly. Without it the action defaults to the
  current ref, which would push to a branch named after the bundle's
  ref rather than the shim's default branch.
* Push tags, so the "Tag stable release" step is no longer a no-op.
* Skip on `workflow_dispatch`, matching `deploy`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RHtjyXkZh8X16sBgmidSQi
swissspidy mentioned this pull request Aug 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

schlessera Awaiting requested review from schlessera
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review
1 more reviewer
szepeviktor szepeviktor left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

scope:distribution Related to distribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Distribute a single PHAR file as composer package Create a wp-cli-shim

6 participants

Back | FazBrowse Home | New Git URL