Update to libxml2 version incorporating code review feedback - #300
Merged
jimjag merged 4 commits intoApr 1, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Merged
scoder
reviewed
Mar 28, 2024
Comment thread
src/lxml.c
Outdated
Comment thread
src/lxml.c
Outdated
Comment thread
src/lxml.c
Outdated
Co-authored-by: scoder <stefan_ml@behnel.de>
Co-authored-by: scoder <stefan_ml@behnel.de>
Co-authored-by: scoder <stefan_ml@behnel.de>
Copy link
Copy Markdown
Contributor
Author
|
Thanks @scoder, appreciate you taking the time to review here! I committed those suggested changes. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@jimjag I think this one is ready to go and might be good to get merged before a release. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small update to #299 that incorporates the excellent feedback @scoder left on the PR after it was merged. It addresses a couple edge cases where an exception could have been raised and not handled in the original PR.