FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

speed up view, add simd interface to strided view by wolfv · Pull Request #1627 · xtensor-stack/xtensor · GitHub

Repository navigation

speed up view, add simd interface to strided view - #1627

Merged
wolfv merged 5 commits into
xtensor-stack:masterfrom
wolfv:speedyview
Nov 29, 2019
Merged

wolfv merged 5 commits into
xtensor-stack:masterfrom
wolfv:speedyview

Conversation

wolfv commented May 24, 2019

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Any news on this PR?

It failed on the xtest_extended_xmath.average test.

/home/travis/build/QuantStack/xtensor/test/test_extended_xmath_reducers.cpp:810: Failure
Value of: xt::allclose(av, py_av)
  Actual: false
Expected: true
[  FAILED  ] xtest_extended_xmath.average (0 ms)

Copy link
Copy Markdown
Member

Yes we have a vicious bug in release when TBB is enable and all the tests are run. (Running only the failing tests with the same build options makes them magically pass).
We have been quite busy these two last weeks with workshops and conferences, we should have more time to investigate this now.

Copy link
Copy Markdown
Contributor

What is the status on this? I just tested it on my machine and the performance gain for calculating the variance is about factor 100 on my machine

Copy link
Copy Markdown
Member

The status has not evolved since June, we still have some weird bug on the CI when TBB is enabled. (Now we also have some conflicts due to the recent refactoring in xtensor).

Copy link
Copy Markdown
Contributor

I am also interested in this, we use a lot of strided views.

JohanMabille force-pushed the speedyview branch 5 times, most recently from c08dcba to 91ed927 Compare November 28, 2019 23:58

Copy link
Copy Markdown
Member

JohanMabille force-pushed the speedyview branch 5 times, most recently from fc2427a to c4f0e11 Compare November 29, 2019 09:57

Copy link
Copy Markdown
Contributor

Santa may be early this year? Two thumbs up for speedy views!!!

Copy link
Copy Markdown
Member

Well we still have random issues with TBB (and now OpenMP) :/

JohanMabille force-pushed the speedyview branch 2 times, most recently from 25f7699 to 7d42a17 Compare November 29, 2019 10:50
wolfv merged commit ef28f5a into xtensor-stack:master Nov 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL