Add rvalue qualified xstrided_view_base::storage - #2413
Draft
AntoinePrv wants to merge 1 commit into
Draft
AntoinePrv wants to merge 1 commit into
AntoinePrv wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
AntoinePrv
marked this pull request as draft
July 13, 2021 19:42
Copy link
Copy Markdown
Contributor
Author
|
@JohanMabille , I haven't been able to figure out this build error: .../include/xtensor/xstrided_view_base.hpp:316:11: error: rvalue reference to type 'xt::xstrided_view_base<... >::storage_type' (aka 'xt::uvector<int, std::allocator<int> >') cannot bind to lvalue of type 'xt::uvector<int, std::allocator<int> >' I (sort of) understand rvalue references cannot bind to lvalue, but I don't understand why this is happening. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fixes #2401