FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix xmasked_view with xfunction by gouarin · Pull Request #2501 · xtensor-stack/xtensor · GitHub

Repository navigation

fix xmasked_view with xfunction - #2501

Open
gouarin wants to merge 3 commits into
xtensor-stack:masterfrom
gouarin:fix-masked-view
Open

gouarin wants to merge 3 commits into
xtensor-stack:masterfrom
gouarin:fix-masked-view

Conversation

gouarin commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

tdegeus commented Apr 26, 2022

Copy link
Copy Markdown
Member

@gouarin I'm not a big expert here so I cannot estimate what it takes to fix this. A question though: Should be aim to include this in the next release.

gouarin commented Apr 26, 2022

Copy link
Copy Markdown
Member Author

I fixed the first issue but a new one appears. I had a discussion with @JohanMabille about that and it's not so easy to fix it.
We will take time together to find a solution after his vacation.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL