Avoid warnings in compiler version checks - #2781
Merged
JohanMabille merged 2 commits intoNov 20, 2024
Merged
JohanMabille merged 2 commits into
JohanMabille merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
4 tasks done
Copy link
Copy Markdown
|
This looks like a nice small PR that would solve already a lot of warnings that I get. Could this PR be merged? I addressed the same warnings in #2801, as well as a few more, so this PR has a lower threshold to merge. If this gets merged I'll rebase my branch so that it only addresses the warnings not yet covered here. |
Sorry, something went wrong.
JohanMabille
approved these changes
Nov 20, 2024
Copy link
Copy Markdown
Member
|
I'll rebase to have the CI run and merge after. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 13 may give warnings like:
/home/maik/scratch/schaap/everybeam/include/xtensor/xutils.hpp:33:6: error: "_MSC_VER" is not defined, evaluates to 0 [-Werror=undef] 33 | #if (_MSC_VER >= 1910) | ^~~~~~~~ In file included from /home/maik/scratch/schaap/everybeam/include/xtensor/xcontainer.hpp:25, from /home/maik/scratch/schaap/everybeam/include/xtensor/xtensor.hpp:20: /home/maik/scratch/schaap/everybeam/include/xtensor/xmath.hpp:1077:69: error: "GCC_VERSION" is not defined, evaluates to 0 [-Werror=undef] 1077 | #if (defined(_MSC_VER) && _MSC_VER < 1910) || (defined(__GNUC__) && GCC_VERSION < 49999) | ^~~~~~~~~~~This PR avoids these warnings by