Fix SIMD assignment to xfunctor_view destinations - #2932
Open
Alex-PLACET wants to merge 2 commits into
Open
Alex-PLACET wants to merge 2 commits into
Alex-PLACET wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
xt::real(e) = w failed to compile with XTENSOR_USE_XSIMD: the SIMD gate only probed load_simd, but the linear assigner also needs data() on the destination, which functor views lack. Gate the SIMD paths on data_interface_expression<E1> instead; functor views fall back to scalar assignment while containers keep the SIMD path. Adds a regression test (test_xcomplex.assign_to_real_part).
Copy link
Copy Markdown
Contributor
Merging this PR will not alter performance✅ 255 untouched benchmarks Comparing Alex-PLACET:fix-2892 (4597ce5) with master (d9a57b6) |
Sorry, something went wrong.
Comment thread
include/xtensor/core/xassign.hpp
| static constexpr bool simd_interface() | ||
| { | ||
| return has_simd_interface<E1, requested_value_type>() | ||
| return data_interface_expression<E1> && has_simd_interface<E1, requested_value_type>() |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
data_interface_expression is orthogonal to simd_interface and should not be required here. What is the current issue with SIMD assignment to xfunctor_view destination?
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.