Fix squeeze offset for sliced views - #2933
Merged
JohanMabille merged 1 commit intoOct 20, 2026
Merged
JohanMabille merged 1 commit into
JohanMabille merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Tyagiquamar
force-pushed
the
fix/squeeze-sliced-view-offset
branch
from
1433579 to
8d84b6a
Compare
October 12, 2026 12:50
Copy link
Copy Markdown
Contributor
Merging this PR will not alter performance⚠️ 1 benchmark measured no execution time
✅ 255 untouched benchmarks Comparing Tyagiquamar:fix/squeeze-sliced-view-offset (8d84b6a) with master (d9a57b6) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for the fix! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squeezing a sliced view now retains its data offset instead of reading from the start of the underlying tensor. Both squeeze overloads reuse the existing offset helper; expressions without a data interface keep their zero-offset fallback.
Fixes #2834.
Validation in Docker (Ubuntu 24.04, clang 18.1.3, C++20): the added regression failed before the fix with {1,2} instead of {2,3}. After the fix, the focused squeeze tests passed in both row-major and column-major configurations (2 test cases, 12 assertions each). The modified header and test passed clang-format-18 --dry-run --Werror.