Adding examples (full-working) - #218
Closed
tdegeus wants to merge 1 commit into
Closed
tdegeus wants to merge 1 commit into
tdegeus wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Cool! If you use this CMake file here: https://github.com/xtensor-stack/xtensor-python/blob/master/cmake/FindNumPy.cmake I think it should help in finding the include directory for the NumPy headers. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks @wolfv . By default my cmake does not find the FindNumPy.cmake when I install xtensor-python with conda. I.e. with find_package(NumPy REQUIRED)I get CMake Warning at CMakeLists.txt:9 (find_package):
By not providing "FindNumPy.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "NumPy", but
CMake did not find one.
Could not find a package configuration file provided by "NumPy" with any of
the following names:
NumPyConfig.cmake
numpy-config.cmake
Add the installation prefix of "NumPy" to CMAKE_PREFIX_PATH or set
"NumPy_DIR" to a directory containing one of the above files. If "NumPy"
provides a separate development package or SDK, be sure it has been
installed. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm starting adding some full-working examples to the docs. At first I will implement the strategies described by @JohanMabille here
I'm still having trouble getting the first example working, in particular the CMakeLists.txt is apparently insufficient as ~/miniconda3/envs/test/include/xtensor-python/pycontainer.hpp:28:10: fatal error: 'numpy/arrayobject.h' file not found
Thereafter it would be good to hear your opinions on what kind of examples to include @wolfv @JohanMabille @SylvainCorlay. If you agree I would probably include building the example in the CI.