add rank member to rtensor and rarray - #136
Merged
JohanMabille merged 1 commit intoJan 4, 2023
Merged
JohanMabille merged 1 commit into
JohanMabille merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The errors on the CI are not related to this PR. I'm gonna fix them in a separated PR, once it is merged you can rebase this one and everything should be green ;) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Here you go. |
Sorry, something went wrong.
ThibHlln
force-pushed
the
add-rank-member
branch
from
3110368 to
4d7bdc9
Compare
January 4, 2023 07:28
Copy link
Copy Markdown
Contributor
Author
|
Thank you Johan. :-) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Would it be possible to get a new tag/release including the new rank member please? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
sure! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that rtensor and rarray did not have a rank member such that
returns SIZE_MAX instead of 2.
So this PR adds a rank member to these objects, taking inspiration from the one made for xtensor-python (xtensor-stack/xtensor-python#241).