FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implemented resolving AssemblyMetadata, build configuration format strings and build error on dirty repo by 0x6d61726b · Pull Request #14 · ygoe/NetRevisionTask · GitHub

/ NetRevisionTask Public

Implemented resolving AssemblyMetadata, build configuration format strings and build error on dirty repo - #14

Open
0x6d61726b wants to merge 9 commits into
ygoe:masterfrom
0x6d61726b:master
ConversationCommits (9)ChecksFiles changed
Open

Implemented resolving AssemblyMetadata, build configuration format strings and build error on dirty repo#14
0x6d61726b wants to merge 9 commits into
ygoe:masterfrom
0x6d61726b:master

Conversation

0x6d61726b commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

Hello Yves,

I have extended Net Revision Task with the following changes:

  • Implemented resolving of AssemblyMetadata attributes value format strings (enabled by default)
  • BuildTime is updated if GetVersion() is called (otherwise the build time stays constant until the Solution is reloaded)
  • Added {bconf}, {BCONF} and {bconf:<sep>:<ref>} format strings to resolve build configuration names
  • Implemented a RegEx match pattern to trigger a build error if the repository contains modifications

Please let me know if you don't agree with the changes or see potential for optimizations.

Best regards,
Mark

0x6d61726b commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

Hello Ives,

I added another patch to avoid the error message "Revision ID cannot be truncated to dotted-numeric" when the repository was empty and did not yet receive a tag. I can't tell if the solution I have chosen with 56485af is the way to go, but it works for the issue I currently had.

Best regards,
Mark

ygoe commented Nov 18, 2020

Copy link
Copy Markdown
Owner

Just wanted to give a quick feedback. I'm very busy with other time-critical projects at the moment but these changes sound interesting and I'll take a look at them. Please don't be too sad if I won't make it anymore this year.

0x6d61726b commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for your feedback, Yves. I made a local build and can work with it for now. Take your time.

0x6d61726b commented Jul 16, 2023

Copy link
Copy Markdown
Contributor Author

Merged latest changes and fixed conflicts.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL