FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove unreachable duplicate check and add tests by MatrixNeoKozak · Pull Request #6749 · zed-industries/extensions · GitHub

/ extensions Public

Remove unreachable duplicate check and add tests - #6749

Merged
MrSubidubi merged 1 commit into
zed-industries:mainfrom
MatrixNeoKozak:fix/improvement-1783436533263
Jul 29, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Remove unreachable duplicate check and add tests#6749
MrSubidubi merged 1 commit into
zed-industries:mainfrom
MatrixNeoKozak:fix/improvement-1783436533263

Conversation

MatrixNeoKozak commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Removed a redundant duplicate check for expectedSubmoduleName in validateGitmodulesLocations, which acted as dead code. Added comprehensive unit tests to validate the gitmodules locations verification logic.

cla-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @MatrixNeoKozak on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

MrSubidubi commented Jul 14, 2026

Copy link
Copy Markdown
Member

Hey @MatrixNeoKozak could you look into signing the CLA if you want to see this merged?

MatrixNeoKozak commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@cla-bot check

cla-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @MatrixNeoKozak on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

MrSubidubi commented Jul 17, 2026

Copy link
Copy Markdown
Member

Still says you did not sign it

MatrixNeoKozak commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@cla-bot check

cla-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @MatrixNeoKozak on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

MatrixNeoKozak commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@cla-bot check

cla-bot Bot added the cla-signed label Jul 24, 2026

cla-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

MrSubidubi changed the title refactor(validation): remove unreachable duplicate check and add tests Remove unreachable duplicate check and add tests Jul 29, 2026
MrSubidubi added the allow-no-extension Label for PRs that do not change any extension versions label Jul 29, 2026
MrSubidubi mentioned this pull request Jul 29, 2026
Closed
MrSubidubi approved these changes Jul 29, 2026
View reviewed changes

MrSubidubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice, thank you!

MrSubidubi added this pull request to the merge queue Jul 29, 2026
Merged via the queue into zed-industries:main with commit 75bda57 Jul 29, 2026
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MrSubidubi MrSubidubi approved these changes

Assignees

No one assigned

Labels

allow-no-extension Label for PRs that do not change any extension versions cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL