FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] execute autocode from maven by t-8ch · Pull Request #531 · zsmartsystems/com.zsmartsystems.zigbee · GitHub

/ com.zsmartsystems.zigbee Public

[WIP] execute autocode from maven - #531

Open
t-8ch wants to merge 5 commits into
zsmartsystems:XML-autocoderfrom
t-8ch:autocoder-maven
ConversationCommits (5)ChecksFiles changed
Open

[WIP] execute autocode from maven#531
t-8ch wants to merge 5 commits into
zsmartsystems:XML-autocoderfrom
t-8ch:autocoder-maven

Conversation

t-8ch commented Feb 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

As discussed in #527 . This is an early prototype to gather feedback.
The commits are structured as follows:

  1. Delete all generated code, to make it easier to exclude from review
  2. Should probably be applied to master right away.
  3. The logic of the change.
  • Generated source code discovery works in IDEA, eclipse would have to be validated.

Caveats:

  • Currently only supports the base library. The dongle generation is possible as well. Maybe a dedicated mojo per project or via configurations, if they are similar enough.
  • Only maven (no gradle). Is there a reason for two build systems?
  • Executes the generation twice. (once triggered by the maven-source-plugin, may be disabled)

cdjackson commented Feb 12, 2019

Copy link
Copy Markdown
Member

Thanks @t-8ch . I've not looked over this yet as the changes are extensive. I assume that the real changes are only to the POM? Is it possible to leave the existing code included in the repo for now, or does this not work for some reason?

cdjackson commented Feb 12, 2019

Copy link
Copy Markdown
Member

I also note that the build seems to be failing (according the to LGTM CI anyway)...

t-8ch commented Feb 12, 2019

Copy link
Copy Markdown
Contributor Author

You should be able to ignore the first commit completely.
I will take a look at the build.

t-8ch commented Feb 12, 2019

Copy link
Copy Markdown
Contributor Author

Ah, LGTM uses gradle. Is there an inherent reason for both build systems?

cdjackson commented Feb 12, 2019 via email

Copy link
Copy Markdown
Member

t-8ch commented Feb 12, 2019

Copy link
Copy Markdown
Contributor Author

Hm, shouldn't users only consume the .jar file?
It shouldn't matter how it is generated.

cdjackson commented Feb 12, 2019 via email

Copy link
Copy Markdown
Member

t-8ch commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

I will see how it can support both

cdjackson force-pushed the XML-autocoder branch 3 times, most recently from 2eb8eb3 to 1b00b84 Compare March 3, 2019 22:03
cdjackson force-pushed the XML-autocoder branch 2 times, most recently from cc0204a to a47ff1b Compare March 13, 2019 21:52
cdjackson force-pushed the XML-autocoder branch 6 times, most recently from 5c4c587 to d364c8e Compare April 21, 2019 13:46

stale Bot commented Oct 6, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale Bot added the wontfix label Oct 6, 2019
cdjackson added the pinned Will not be closed, even if stale label Oct 6, 2019
stale Bot removed the wontfix label Oct 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pinned Will not be closed, even if stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL