FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simple redirection rules and HTTP404 handling by andyb1979 · Pull Request #177 · ABTSoftware/SciChart.JS.Examples · GitHub

Simple redirection rules and HTTP404 handling - #177

Open
andyb1979 wants to merge 3 commits into
dev_v2.3from
redirections-and-http404
Open

Simple redirection rules and HTTP404 handling#177
andyb1979 wants to merge 3 commits into
dev_v2.3from
redirections-and-http404

Conversation

Copy link
Copy Markdown
Collaborator

I'm sure there's a better way to handle this ...

I wanted to implement some redirection rules for dead pages and HTTP404 handling. I haven't figured out how to set statuscode=404 which is needed

See ./AppRouter/redirectionRules which defines redirection rules

// Redirection URLs from - to
export const REDIRECTION_RULES = new Map<string, string>([
    ["/javascript-ohlc-chart", "javascript-candlestick-chart"],
]);

And App() which processes redirection using

    // Process redirection rules first
    const pathWithoutSlash = location.pathname.endsWith("/") ? location.pathname.slice(0, -1) : location.pathname;
    if (REDIRECTION_RULES.has(pathWithoutSlash)) {
        return <Navigate  to={REDIRECTION_RULES.get(pathWithoutSlash)}/>
    }

Http404 handling is done later on in App() where I have some dodgy logic which needs reviewing

basically

                <AppBarTop toggleDrawer={toggleDrawer} currentExample={currentExample}/>
                {isHttp404 ? <NotFound/> : pageContent}
                <AppFooter/>

which inserts in between the app top bar and footer OR the page content depending on if the URL is recognised or not

There's probably a better way to do this using React Router and <Route path="*"> however I wanted to hide the side menu bar when HTTP404 is detected

andyb1979 requested a review from klishevich December 23, 2022 21:58

codesandbox Bot commented Dec 23, 2022

Copy link
Copy Markdown

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL