This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sure there's a better way to handle this ...
I wanted to implement some redirection rules for dead pages and HTTP404 handling. I haven't figured out how to set statuscode=404 which is needed
See ./AppRouter/redirectionRules which defines redirection rules
// Redirection URLs from - to export const REDIRECTION_RULES = new Map<string, string>([ ["/javascript-ohlc-chart", "javascript-candlestick-chart"], ]);And App() which processes redirection using
// Process redirection rules first const pathWithoutSlash = location.pathname.endsWith("/") ? location.pathname.slice(0, -1) : location.pathname; if (REDIRECTION_RULES.has(pathWithoutSlash)) { return <Navigate to={REDIRECTION_RULES.get(pathWithoutSlash)}/> }Http404 handling is done later on in App() where I have some dodgy logic which needs reviewing
basically
<AppBarTop toggleDrawer={toggleDrawer} currentExample={currentExample}/> {isHttp404 ? <NotFound/> : pageContent} <AppFooter/>which inserts in between the app top bar and footer OR the page content depending on if the URL is recognised or not
There's probably a better way to do this using React Router and <Route path="*"> however I wanted to hide the side menu bar when HTTP404 is detected