Add workflow parameter filtering and Display Logs in workflow UI - #1561
Add workflow parameter filtering and Display Logs in workflow UI#1561hazdl wants to merge 24 commits into
Conversation
Sorry, something went wrong.
This reverts commit ecf0ea58bb19365692a991f388e7474f47b7b025.
This reverts commit 954aadd.
davehadley
left a comment
There was a problem hiding this comment.
sent some comments via slack
Sorry, something went wrong.
|
Maybe for future PRs, it would be better to keep commits meaningful and grouped logically, rather than creating a separate commit for every small file change. Since we follow Conventional Commits and use them for releases, please also keep the format consistent, e.g. fix/feat/chore(scope): message, so the history and release notes stay clean. |
Sorry, something went wrong.
Reviewers
Requested changes must be addressed to merge this pull request.
Summary
This PR combines two enhancements:
Workflow Parameter Filtering --- AP-1206
Display Logs Subscription on Workflow --- AP-1112
Added real time tasks logs, and support for retrieving archived task logs from S3 using:
<workflow-name>/<task-id>/main.log
Running tasks continue to use the existing GraphQL subscription and stream logs in real time
Completed tasks retrieve archived logs from S3
Fixed S3 configuration issues including:
Added filtering of Argo infrastructure log noise from displayed logs
Result
Running task:
Completed task:
Workflow searches can now also be filtered using workflow parameter values.