Make Shadow 8 be compatible with Gradle 9 - #1470
Merged
Goooler merged 21 commits intoJun 24, 2025
Merged
Goooler merged 21 commits into
Goooler merged 21 commits into
Conversation
Goooler
force-pushed
the
g/20250619/gradle-9-for-shadow-8
branch
from
df95c17 to
3e3bf60
Compare
June 19, 2025 02:02
Goooler
force-pushed
the
g/20250619/gradle-9-for-shadow-8
branch
from
aacd607 to
635ab61
Compare
June 19, 2025 13:19
Goooler
marked this pull request as ready for review
June 19, 2025 14:05
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This was
linked to
issues
Jun 19, 2025
ljacomet
reviewed
Jun 19, 2025
ljacomet
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you for looking into this. It is a feedback we have received on the Gradle side that coupling Gradle 9 and Shadow 9 migrations is challenging. Giving the ability to users to migrate on their own pace would be awesome!
Sorry, something went wrong.
Comment thread
gradle/wrapper/gradle-wrapper.properties
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.2-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.0.0-rc-1-bin.zip |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🤔 This may not even be required if you want to keep the change set smaller.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yeah this is unnecessary. But it would be easier to track and test Gradle 9 releases.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
If this looks good to you, I'll merge it and release 8.3.7 tomorrow. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hey @Goooler, The one question I have is how could we confirm that upcoming 8.3.7 would work with both Gradle 8 and 9? Note: I did not look yet for myself, and may not have time before EOD Wednesday (Western European time) |
Sorry, something went wrong.
liutikas
approved these changes
Jun 23, 2025
liutikas
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
It looks reasonable. I haven't tested it though.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I just added Gradle 8.3 into the test matrix, everything looks good for now. |
Sorry, something went wrong.
dongjoon-hyun
added a commit
to apache/spark-kubernetes-operator
that referenced
this pull request
Jan 20, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `com.gradleup.shadow` to 8.3.9. ### Why are the changes needed? To bring the latest bug fixed versions. - https://github.com/GradleUp/shadow/releases/tag/8.3.9 - GradleUp/shadow#1579 - https://github.com/GradleUp/shadow/releases/tag/8.3.8 - GradleUp/shadow#1493 - GradleUp/shadow#1488 - https://github.com/GradleUp/shadow/releases/tag/8.3.7 - GradleUp/shadow#1470 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #469 from dongjoon-hyun/SPARK-55102. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
marcospaulo
pushed a commit
to torad-labs/splice
that referenced
this pull request
Jul 19, 2026
`./gradlew build` (the full gate: assemble + check) failed at configuration
time on `:app:shadowDistTar`:
Could not create task ':app:startShadowScripts'.
> You can't map a property that does not exist: propertyName=mainClassName
Shadow 8.3.5 registers `startShadowScripts` as a `CreateStartScripts` task
whose convention-maps `mainClassName`, a property Gradle 9.0 REMOVED (the
wrapper here is 9.6.1). The app already declares `application { mainClass }`
correctly — the break is purely inside the plugin, so `check` (compile +
tests + detekt + arch-tests) was green while `assemble`'s shadow-dist path
was never exercised.
Shadow 8.3.7 backported the Gradle-9 fix (mainClassName -> mainClass on
CreateStartScripts, GradleUp/shadow#1470); 8.3.9 is the latest 8.x, validated
against Gradle 9.0.0 final (#1557). Staying on the 8.x line keeps the fat-jar
behavior identical (EXCLUDE duplicatesStrategy, no rewritten-plugin API/
service-file changes) — the minimal fix that restores a green distribution
without touching the SPI ServiceLoader packaging. Verified: full `./gradlew
build` green, `:app:shadowJar`/`shadowDistTar`/`shadowDistZip` all execute.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
marcospaulo
added a commit
to torad-labs/splice
that referenced
this pull request
Sep 20, 2026
`./gradlew build` (the full gate: assemble + check) failed at configuration
time on `:app:shadowDistTar`:
Could not create task ':app:startShadowScripts'.
> You can't map a property that does not exist: propertyName=mainClassName
Shadow 8.3.5 registers `startShadowScripts` as a `CreateStartScripts` task
whose convention-maps `mainClassName`, a property Gradle 9.0 REMOVED (the
wrapper here is 9.6.1). The app already declares `application { mainClass }`
correctly — the break is purely inside the plugin, so `check` (compile +
tests + detekt + arch-tests) was green while `assemble`'s shadow-dist path
was never exercised.
Shadow 8.3.7 backported the Gradle-9 fix (mainClassName -> mainClass on
CreateStartScripts, GradleUp/shadow#1470); 8.3.9 is the latest 8.x, validated
against Gradle 9.0.0 final (#1557). Staying on the 8.x line keeps the fat-jar
behavior identical (EXCLUDE duplicatesStrategy, no rewritten-plugin API/
service-file changes) — the minimal fix that restores a green distribution
without touching the SPI ServiceLoader packaging. Verified: full `./gradlew
build` green, `:app:shadowJar`/`shadowDistTar`/`shadowDistZip` all execute.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.