| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@pllim this should hopefully be a good way forward instead of using tox-conda; please let me know your thoughts. I don't think this should go into 3.0.0 at the moment, probably 4.0.0 eventually |
Sorry, something went wrong.
|
Ooo thanks! Is there a way to test with this branch over at https://github.com/spacetelescope/wfc3tools ? |
Sorry, something went wrong.
|
Yes! Just make a PR that changes this line: - uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@2835f0cacddf3f8de198db9afdb5354a5cebe0ef # v2.6.3
+ uses: zacharyburnett/github-actions-workflows/.github/workflows/tox.yml@install_conda_packages_directly
|
Sorry, something went wrong.
Sorry, something went wrong.
|
actually @Cadair if we can squeeze another PR into the 3.0.0 release, this one seems to be working well |
Sorry, something went wrong.
|
wait no never mind, I still need to use matrix.conda_packages instead of inputs.conda_packages |
Sorry, something went wrong.
|
ok, fixed |
Sorry, something went wrong.
Sorry, something went wrong.
|
This let's you install binaries for use in tox but not libraries right? You couldn't import a package installed like this? |
Sorry, something went wrong.
| type: string | ||
| conda: | ||
| description: Whether to test with conda (deprecated) | ||
| conda_packages: |
There was a problem hiding this comment.
Given how this is separate from tox, I wonder if it would be best folded into libraries like the system package managers?
Sorry, something went wrong.
There was a problem hiding this comment.
Oh that's a good idea!
Sorry, something went wrong.
There was a problem hiding this comment.
actually on second thought, maybe we should keep them separate; the conda environment is distinct from the runner and platform, and you can install both
Sorry, something went wrong.
There was a problem hiding this comment.
I'm still not entirely sure what the limits of this functionality are so hard to judge. Can you use this to install C libraries and have them picked up inside tox?
Sorry, something went wrong.
There was a problem hiding this comment.
yes, anything in the conda environment is exposed to tox via allowlist_externals
Sorry, something went wrong.
There was a problem hiding this comment.
allowlist_externals is for command line tools only no?
Sorry, something went wrong.
There was a problem hiding this comment.
oh yes you're right. The only usage of it I've seen is for testing wfc3tools with hstcal
I'm not sure if C libraries will be exposed, but I assume they should be since Conda modifies that path
Sorry, something went wrong.
There was a problem hiding this comment.
I'll have to experiment. I still think that this is still a good match for libraries? There's not any meaningful difference between using conda like this and homebrew?
Sorry, something went wrong.
There was a problem hiding this comment.
I guess I don't really understand how the libraries installer works, so I'm fine with pushing this PR off to 4.0 if you think it can be better
Sorry, something went wrong.
There was a problem hiding this comment.
I've completely failed to write a test which checks to see if you can load a c library installed with conda or apt inside the tox env. Feel free to have a play if you want.
I think this functionality should be in libraries, I think it's the sensible place for it to be. Note, that with your current implementation I haven't been able to install a conda package on a per-env basis, you can see this in my broken test commit.
Sorry, something went wrong.
|
I'm in no mad rush for 3.0 fwiw, so happy to get this in. |
Sorry, something went wrong.
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 6 6
=======================================
Hits 4 4
Misses 2 2 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
|
muffled screaming |
Sorry, something went wrong.
|
for some reason the clib test with conda_packages: specified - linux: libraries-clibrary
conda_packages: libffcallisn't actually picking up the conda packages and is just setting up Python with setup-python instead: |
Sorry, something went wrong.
|
Would you mind if we bumped this to a future release while we get on top of it? I'd like to release 3.0 before I go on parental leave? |
Sorry, something went wrong.
|
sure thing, lets bump it to 4.0 |
Sorry, something went wrong.
for more information, see https://pre-commit.ci
| Back | FazBrowse Home | New Git URL |
alternative to #361
replace the conda: parameter (which invoked the now-archived tox-conda) with conda_packages:.
If the user populates conda_packages then the workflow sets up a Mamba environment that tox runs within.
To migrate from tox-conda, copy conda_deps from tox.ini to conda_packages in the test workflow, and then also remember to list any non-Python Conda packages in allowlist_externals:
allowlist_externals = hstcalthis will require a major version bump