feature: adding smarter unit test execution - #5966
Conversation
Sorry, something went wrong.
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
…ow too Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
| default=None, | ||
| ) | ||
| @click.option( | ||
| "--all-tests", |
There was a problem hiding this comment.
Most of the other flags are verb_*. should this be --include_all_tests, or something similar?
Sorry, something went wrong.
|
Nice idea! I do worry about the default behavior being only running impacted model's unit tests. An indirect model change could take place (i.e., things like a SQLGlot upgrade changing rendering/types, or an engine adapter change) and then tests would fail silently for a long time before it's caught. Also, would be good to add a console output (x tests skipped) when only some tests were selected. |
Sorry, something went wrong.
|
@mday-io -- yeah, now that I have time to think about it, I think it would make more sense to flip the logic I have and maybe add a flag for smarter unit test execution, thoughts? That way we wouldn't change default behavior and its opt-in. I like the Skipped X tests as well. Just need to think of what the flag would be called. Maybe --only-relevant-tests -- not sure |
Sorry, something went wrong.
|
yeah, I think that's the safest option for now. and, what about --test-changed-only which auto-passes the list of changed models in. and then also add --test-model TEXT which the user can specify which to run (i.e., orders_*, to parallel --select-model) |
Sorry, something went wrong.
…est command Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Description
Addresses #5965
Test Plan
Checklist