| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…polation time The lerp smoothing pass used by the Lerp and SmoothDampening interpolation types applied a fixed factor of 1.0 minus the maximum interpolation time once per frame, with no delta time. The wall clock smoothing rate therefore scaled with the frame rate, so the same setting smoothed by different amounts on different hardware. The factor is now raised to the number of 60fps reference frames elapsed, which makes the rate a function of elapsed time. Results at 60fps are unchanged for every legal setting. Separately, a maximum interpolation time of 1.0 (the upper bound of the inspector range) produced a factor of exactly 0, so the interpolated value never advanced and the transform stopped moving entirely on all three axes. The retained portion is now clamped just below 1.0. This is an independent defect, as raising 1.0 to any power is still 1.0. The LegacyLerp path was already frame rate correct and is unchanged. The documentation on the lerp smoothing fields described the LegacyLerp formula for all interpolation types and has been corrected.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4132 +/- ##
=================================================
+ Coverage 78.01% 78.04% +0.02%
=================================================
Files 153 153
Lines 26260 26268 +8
=================================================
+ Hits 20486 20500 +14
+ Misses 5774 5768 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes
|
Sorry, something went wrong.
There was a problem hiding this comment.
The time-based smoothing implementation correctly preserves the 60 Hz behavior for the updated interpolation modes, but its public documentation now overstates the guarantee for the legacy path.
Reviewed commit 363c94d
🤖 Helpful? 👍/👎
Sorry, something went wrong.
…ime of 1.0 Clamping to k_MaximumLerpSmoothRetention flattened everything above it, so 0.995 smoothed at the same rate as 0.99 and stopped honoring "higher is smoother". Clamp to the legal range first and substitute only at the freezing endpoint. Also corrects the lerp smoothing remarks: LegacyLerp still applies deltaTime / MaximumInterpolationTime per frame, so the frame rate independence claim only holds for Lerp and SmoothDampening.
| Back | FazBrowse Home | New Git URL |
Purpose of this PR
This is an up-port of #4130
(see original PR for extended details)
Jira ticket
NA
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Automated tests:
Does the change require QA team to:
Up-port
Not needed (this is an up-port).
Backports
Not needed.