doxbee-async and doxbee-promise: add side-effects - #247
Conversation
Sorry, something went wrong.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sorry, something went wrong.
|
I could not really observe any score changes (might be worth rechecking): command = ~/.jsvu/bin/javascriptcore ./cli.js -- doxbee-async
runs = 51
sum = 23295.31
avg = 456.7707843137255
geomean = 455.30697949601443
min = 344.0 max = 490.0
result = 457.0 ± 35.0(7.7%)
................................................................................
Skipping 5 outliers
5 ▅█▂ █▅
0 ▄ ▄ ▄ ▄ ▄ ▇▄▄▄▄▄ ▇▄▇▄ ▇ ▇███▄██▄▄
365 425.5 486
................................................................................
command = ~/.jsvu/bin/v8 ./cli.js -- doxbee-async
runs = 29
sum = 13575.28
avg = 468.11310344827587
geomean = 467.95769924053457
min = 443.0 max = 484.0
result = 468.0 ± 12.0(2.6%)
................................................................................
Skipping 2 outliers
2 █ ██
0 █ █ █ ██ █ █ █ ██ ██ █ █████ ███ █ █
443 462.0 481
................................................................................
After: command = ~/.jsvu/bin/javascriptcore ./cli.js -- doxbee-async
runs = 46
sum = 20927.64
avg = 454.9486956521739
geomean = 453.7823474275458
min = 350.0 max = 483.0
result = 455.0 ± 32.0(6.94%)
................................................................................
Skipping 4 outliers
3 ▃ ▃ ▃██ █ ▃
0 ▆ ▆ ▆ ▆ ▆ ▆ ▆▆ ▆▆▆ ▆ ▆ ▆▆ ▆█▆█▆▆▆▆███▆█▆▆█
387 434.5 482
................................................................................
command = ~/.jsvu/bin/v8 ./cli.js -- doxbee-async
runs = 29
sum = 13533.57
avg = 466.6748275862069
geomean = 466.2300745843536
min = 418.0 max = 496.0
result = 467.0 ± 21.0(4.43%)
................................................................................
Skipping 2 outliers
2 ██ █ █
0 █ █ █ █ ██ ███ █ ██ █ ██ █ █ █ ██ ██
437 465.5 494
................................................................................
|
Sorry, something went wrong.
|
I suggest doing similar in doxbee-promise too. Right now, dummy_1 etc. are not having side-effect much (it is just returning Promise.resolve(undefined). |
Sorry, something went wrong.
|
Weirdly enough I start to see perf differences now
|
Sorry, something went wrong.
| } | ||
| async function dummy_2(a) { | ||
| Queryish.count++; | ||
| } |
There was a problem hiding this comment.
They should avoid using async, and do
function dummy_1() {
Queryish.count++;
return Promise.resolve(undefined);
}
function dummy_2(a) {
Queryish.count++;
return Promise.resolve(undefined);
}
because that's the purpose of this doxbee-promise (not async, that's tested in doxbee-async. testing chain of promises).
Sorry, something went wrong.
There was a problem hiding this comment.
I'm still observing quite a diff even with this fixed for JSC (almost none for V8):
Before: 321.0 ± 11.0(3.35%)
After: 309.0 ± 13.0(4.24%)
Sorry, something went wrong.
Add Queryish.count and use it as simple side-effect in the dummy functions.