FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add JSON output of `go env` and some env as strings by lucacome · Pull Request #334 · actions/setup-go · GitHub

/ setup-go Public

Add JSON output of go env and some env as strings - #334

Open
lucacome wants to merge 1 commit into
actions:mainfrom
lucacome:add-env
ConversationCommits (1)ChecksFiles changed
Open

Add JSON output of go env and some env as strings#334
lucacome wants to merge 1 commit into
actions:mainfrom
lucacome:add-env

Conversation

lucacome commented Feb 16, 2023 •
edited
Loading

Copy link
Copy Markdown

Description:
Additional outputs are:

  • GOPATH as go-path string
    - GOROOT as go-root string
  • GOMOD as go-mod string
  • GOCACHE as go-cache string
  • GOMODCACHE as go-mod-cache string
  • go env as go-env JSON

Related issue:
Closes #54

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

lucacome requested a review from a team as a code owner February 16, 2023 03:38
lucacome mentioned this pull request Feb 16, 2023
Open
lucacome force-pushed the add-env branch 3 times, most recently from 801d939 to e5fda20 Compare February 22, 2023 07:34

lucacome commented Feb 28, 2023

Copy link
Copy Markdown
Author

@marko-zivic-93 could you approve the CI run again? 🙏

lucacome commented Feb 28, 2023

Copy link
Copy Markdown
Author

Not really sure why it failed basic validation on windows...maybe a flaky test?

lucacome force-pushed the add-env branch 2 times, most recently from 7d76f7a to 2c81452 Compare March 14, 2023 01:02

mvdan commented Mar 27, 2023 •
edited
Loading

Copy link
Copy Markdown

action.yml appears to be missing go-cache, FYI. It would be nice to include all the other values from go env as well. For example, GOOS, GOARCH, GOPROXY, and GOAMD64 may be useful. We could carefully maintain a list of which ones are interesting or useful, but I would personally just expose all 39 of them. I imagine we could auto-generate the list to include in action.yaml.

I'm also thinking that it would be nicest if we could use the exact same names that go env uses. Otherwise I have to remind myself how each one of them was transformed, because there's a rather arbitrary choice about where the dashes are inserted. For example, would GOSUMDB be go-sumdb or go-sum-db? Some of its names, like CGO_ENABLED, already use underscores as well - so either cgo-enabled or cgo_enabled would be weird.

I would personally expose each one of them as-is, uppercase and all, like steps.setup-go.outputs.GOCACHE. Or, if we want them to have a common prefix to clarify that they come from go env, perhaps steps.setup-go.outputs.env_GOCACHE, though I don't think it's necessary. The fact that they are uppercase should be enough of a signal.

lucacome commented Mar 28, 2023

Copy link
Copy Markdown
Author

Thanks for catching that @mvdan I've added go-cache to action.yml.

As for the naming, I was using the same pattern used in the other variables, but I'm happy to change them if people think that's a better approach. As for exposing all of them, I didn't want to pollute the outputs and I'm not sure how we could auto-generate them... 😅

Some guidance from the maintainers would be appreciated 🙏

lucacome commented Jun 6, 2023

Copy link
Copy Markdown
Author

is there anything I can do to get this PR reviewed?

mvdan commented Jun 6, 2023

Copy link
Copy Markdown

cc @dmitry-shibanov :)

Erictorrm commented Jun 13, 2023

Copy link
Copy Markdown

Duplicate of #

IvanZosimov self-requested a review July 17, 2023 07:33
dsame linked an issue Aug 1, 2023 that may be closed by this pull request
setup-go action should allow for existing cache files #403
Closed
5 tasks
dsame removed a link to an issue Aug 2, 2023
setup-go action should allow for existing cache files #403
Closed
5 tasks
dsame reviewed Aug 24, 2023
View reviewed changes
Comment thread src/main.ts
core.setOutput('go-root', goEnvJson['GOROOT']);
core.setOutput('go-cache', goEnvJson['GOCACHE']);
core.setOutput('go-mod-cache', goEnvJson['GOMODCACHE']);
core.setOutput('go-env', goEnvJson);

dsame Aug 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hello @lucacome

Can you please remove the most outputs except these 3 ones

    core.setOutput('go-version', parsedGoVersion);
    core.setOutput('go-cache', goEnvJson['GOCACHE']);
    core.setOutput('go-mod-cache', goEnvJson['GOMODCACHE']);

The others does not seem relate to any real-world use cases.

lucacome Sep 18, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @dsame

I'm personally interested in go-path so I would like to keep that one as well 😅
Are you saying to also remove core.setOutput('go-env', goEnvJson); ?

mvdan Sep 18, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm still of the opinion that the entire go env -json should be exposed in its entirety - I find most of the vars useful.

lucacome commented Oct 25, 2024

Copy link
Copy Markdown
Author

What needs to be done to get this merged?

simao-silva commented Feb 19, 2025

Copy link
Copy Markdown

What is the status of this?

Add JSON output of go env and some env as strings
18710d6 
Additional outputs are:
- GOPATH as `go-path` string
- GOMOD as `go-mod` string
- GOCACHE as `go-cache` string
- GOMODCACHE as `go-mod-cache` string
- `go env` as `go-env` JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

IvanZosimov Awaiting requested review from IvanZosimov
2 more reviewers
dsame dsame approved these changes
mvdan mvdan left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Outputting or Exporting Go Environment Variables

5 participants

Back | FazBrowse Home | New Git URL