FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add cache-restore-only input by dsame · Pull Request #400 · actions/setup-go · GitHub

Add cache-restore-only input - #400

Open
dsame wants to merge 1 commit into
actions:mainfrom
akv-platform:restore-cache-only
Open

dsame wants to merge 1 commit into
actions:mainfrom
akv-platform:restore-cache-only

Conversation

dsame commented Jul 25, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

The use-cases are:

The suggested workaround does not really work because it requires the users to re-engineer and reconstruct the automatically created cache key

To avoid it i introduced new input cache-restore-only that makes build to skip caching without making user to deal with cache key

Related issue:
link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

dsame requested a review from a team as a code owner July 25, 2023 18:07
dsame force-pushed the restore-cache-only branch from b90ed1b to 5525a13 Compare July 26, 2023 06:58
dsame linked an issue Jul 26, 2023 that may be closed by this pull request
dsame force-pushed the restore-cache-only branch from 5525a13 to 0f07568 Compare July 26, 2023 07:17
dsame force-pushed the restore-cache-only branch from 0f07568 to 28cfea2 Compare July 26, 2023 07:25

freeformz commented Aug 4, 2023
edited
Loading

Copy link
Copy Markdown

Yes please. I understand the arguments against, but respectfully disagree - it's a pita to have to reverse engineer the key setup and copy it into a ton of different repo workflows. And then there is the possibility of future changes. I'd like the setup-go action to "just handle all of that". i.e. I think the complexity should be shifted away from users.

Copy link
Copy Markdown

Can this PR get reviewed? A use case I have for this is to be able to speed up deployments. Currently waiting for the go cache cleanup to push at the end adds a noticeable delay and the deployment build is not going to produce a useful cache that doesn't already exist. I am looking to see if it is spending time caching unnecessary things and if there are settings for that, but would be nice to avoid altogether in this case.

devnev commented Aug 28, 2024

Copy link
Copy Markdown

This would be great to get merged. @HarithaVattikuti ?

bconway commented Jan 31, 2025

Copy link
Copy Markdown

This would be a great (and simple) addition.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to restore cache only

5 participants


Back | FazBrowse Home | New Git URL