Add support for multiple Maven servers - #1239
Merged
brunoborges merged 1 commit intoAug 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds first-class support for configuring multiple Maven <server> credential entries in the generated settings.xml, enabling workflows to publish to release/snapshot/private repositories without custom settings.xml patching. It introduces a new multiline input (mvn-server-credentials) that is parsed, validated (malformed entries + duplicate IDs rejected), and used preferentially while preserving the existing single-server inputs (and deprecated aliases) as a fallback.
Changes:
- Add a new mvn-server-credentials multiline input and plumb it through authentication settings generation.
- Implement parsing/validation for multiple server credential entries and update settings.xml generation to emit multiple ordered <server> blocks.
- Update docs, tests, and bundled dist/ artifacts to match the new behavior.
| File | Description |
|---|---|
| src/constants.ts | Adds the mvn-server-credentials input constant. |
| src/auth.ts | Adds parsing + selection logic for multiple servers and updates settings.xml generation to emit multiple <server> entries. |
| tests/auth.test.ts | Adds coverage for parsing, validation, precedence rules, and multi-server XML output ordering. |
| action.yml | Documents the new multiline input at the action interface level. |
| README.md | Adds the new input to the published inputs table. |
| docs/advanced-usage.md | Adds an “Publishing to multiple Maven servers” section with an example and expected XML output. |
| dist/setup/index.js | Updates bundled constants export to include the new input. |
| dist/setup/81.index.js | Updates bundled auth logic for multi-server parsing/generation. |
| dist/cleanup/index.js | Updates bundled constants to include the new input (unused in cleanup). |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 6/9 changed files
- Comments generated: 0
- Review effort level: Lite
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Maven workflows that publish to separate release, snapshot, or private repositories currently have to generate or patch settings.xml themselves. This adds a structured mvn-server-credentials multiline input that generates multiple ordered <server> entries from environment variable names.
The parser rejects malformed entries and duplicate server IDs, while existing single-server inputs and deprecated aliases remain the fallback when the new input is absent. XML escaping, GPG profile behavior, settings overwrite handling, documentation, tests, and checked-in action bundles are updated consistently.
Related issue:
Fixes: #85
Check list: